Changeset 10985

Timestamp:

08/03/2016 12:06:25 AM (8 years ago)

Author:

mercime

Message:

Groups: Improve markup of the input controls in the Group Edit screen.

Props dcavins, mercime.
Fixes #7211.

Location:

trunk/src/bp-groups

Files:

• admin/css/admin-rtl.css (modified) (2 diffs)
• admin/css/admin.css (modified) (2 diffs)
• bp-groups-admin.php (modified) (3 diffs)

trunk/src/bp-groups/admin/css/admin-rtl.css

@@ -29 +29 @@
     margin: 0;
 }
-#bp_group_settings legend {
-    margin: 10px 0;
+.bp-groups-settings-section {
+    margin-top: 10px;
+    line-height: 2em;
+}
+.bp-groups-settings-section legend {
+    margin-top: 10px;
     font-weight: bold;
 }
-#bp_group_settings ul {
-    margin: 0;
-}
-.bp-groups-settings-section {
-    margin-top: 10px;
+.bp-groups-settings-section label {
+    clear: left;
+    display: block;
+    float: left;
+    vertical-align: middle;
 }
 #bp-groups-permalink-box {
@@ -85 +89 @@
     padding-left: 20px;
 }
+
+@media screen and (max-width: 782px) {
+    .bp-groups-settings-section label {
+        margin: 0.25em 0;
+    }
+}

trunk/src/bp-groups/admin/css/admin.css

@@ -29 +29 @@
     margin: 0;
 }
-#bp_group_settings legend {
-    margin: 10px 0;
+.bp-groups-settings-section {
+    margin-top: 10px;
+    line-height: 2em;
+}
+.bp-groups-settings-section legend {
+    margin-top: 10px;
     font-weight: bold;
 }
-#bp_group_settings ul {
-    margin: 0;
-}
-.bp-groups-settings-section {
-    margin-top: 10px;
+.bp-groups-settings-section label {
+    clear: left;
+    display: block;
+    float: left;
+    vertical-align: middle;
 }
 #bp-groups-permalink-box {
@@ -85 +89 @@
     padding-right: 20px;
 }
+
+@media screen and (max-width: 782px) {
+    .bp-groups-settings-section label {
+        margin: 0.25em 0;
+    }
+}

trunk/src/bp-groups/bp-groups-admin.php

@@ -799 +799 @@
     <?php if ( bp_is_active( 'forums' ) ) : ?>
         <div class="bp-groups-settings-section" id="bp-groups-settings-section-forum">
-            <label for="group-show-forum"><input type="checkbox" name="group-show-forum" id="group-show-forum" <?php checked( $item->enable_forum ) ?> /> <?php _e( 'Enable discussion forum', 'buddypress' ) ?><br />
+            <label for="group-show-forum"><input type="checkbox" name="group-show-forum" id="group-show-forum" <?php checked( $item->enable_forum ) ?> /> <?php _e( 'Enable discussion forum', 'buddypress' ) ?></label>
         </div>
     <?php endif; ?>
@@ -807 +807 @@
             <legend><?php _e( 'Privacy', 'buddypress' ); ?></legend>
 
-            <ul>
-                <li><input type="radio" name="group-status" id="bp-group-status-public" value="public" <?php checked( $item->status, 'public' ) ?> /><label for="bp-group-status-public"><?php _e( 'Public', 'buddypress' ) ?></label></li>
-                <li><input type="radio" name="group-status" id="bp-group-status-private" value="private" <?php checked( $item->status, 'private' ) ?> /><label for="bp-group-status-private"><?php _e( 'Private', 'buddypress' ) ?></label></li>
-                <li><input type="radio" name="group-status" id="bp-group-status-hidden" value="hidden" <?php checked( $item->status, 'hidden' ) ?> /><label for="bp-group-status-hidden"><?php _e( 'Hidden', 'buddypress' ) ?></label></li>
-            </ul>
+            <label for="bp-group-status-public"><input type="radio" name="group-status" id="bp-group-status-public" value="public" <?php checked( $item->status, 'public' ) ?> /><?php _e( 'Public', 'buddypress' ) ?></label>
+            <label for="bp-group-status-private"><input type="radio" name="group-status" id="bp-group-status-private" value="private" <?php checked( $item->status, 'private' ) ?> /><?php _e( 'Private', 'buddypress' ) ?></label>
+            <label for="bp-group-status-hidden"><input type="radio" name="group-status" id="bp-group-status-hidden" value="hidden" <?php checked( $item->status, 'hidden' ) ?> /><?php _e( 'Hidden', 'buddypress' ) ?></label>
         </fieldset>
     </div>
@@ -819 +817 @@
             <legend><?php _e( 'Who can invite others to this group?', 'buddypress' ); ?></legend>
 
-            <ul>
-                <li><input type="radio" name="group-invite-status" id="bp-group-invite-status-members" value="members" <?php checked( $invite_status, 'members' ) ?> /><label for="bp-group-invite-status-members"><?php _e( 'All group members', 'buddypress' ) ?></label></li>
-                <li><input type="radio" name="group-invite-status" id="bp-group-invite-status-mods" value="mods" <?php checked( $invite_status, 'mods' ) ?> /><label for="bp-group-invite-status-mods"><?php _e( 'Group admins and mods only', 'buddypress' ) ?></label></li>
-                <li><input type="radio" name="group-invite-status" id="bp-group-invite-status-admins" value="admins" <?php checked( $invite_status, 'admins' ) ?> /><label for="bp-group-invite-status-admins"><?php _e( 'Group admins only', 'buddypress' ) ?></label></li>
-            </ul>
+            <label for="bp-group-invite-status-members"><input type="radio" name="group-invite-status" id="bp-group-invite-status-members" value="members" <?php checked( $invite_status, 'members' ) ?> /><?php _e( 'All group members', 'buddypress' ) ?></label>
+            <label for="bp-group-invite-status-mods"><input type="radio" name="group-invite-status" id="bp-group-invite-status-mods" value="mods" <?php checked( $invite_status, 'mods' ) ?> /><?php _e( 'Group admins and mods only', 'buddypress' ) ?></label>
+            <label for="bp-group-invite-status-admins"><input type="radio" name="group-invite-status" id="bp-group-invite-status-admins" value="admins" <?php checked( $invite_status, 'admins' ) ?> /><?php _e( 'Group admins only', 'buddypress' ) ?></label>
         </fieldset>
     </div>