Opened 9 years ago
Closed 9 years ago
#7211 closed enhancement (fixed)
Simplify markup in settings pane of edit group screen in wp-admin.
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.7 | Priority: | normal |
Severity: | normal | Version: | 2.6.1.1 |
Component: | Groups | Keywords: | has-patch commit |
Cc: |
Description
While working on hierarchical groups, @mercime and I talked about the markup in the "Settings" pane of the group edit screen in WP Admin. At the moment, it adds an unordered list structure around the inputs and labels, which is not ideal for screen readers.
I looked at how WP structures similar input, like the "Post Format" meta box, and it uses <br>
s to form a list. So I've updated the structure and styling for our meta box inputs to not change visually while using the simplified html structure. I've also replaced id selectors with class selectors where possible.
Attachments (6)
Change History (15)
#2
@
9 years ago
Thanks for creating the ticket @dcavins :)
Attached is a patch which removes the <br />
tags as well and adds spaces between radio
and checkbox
input controls for mobile view.
#3
@
9 years ago
- Keywords commit added
I like making the <label>
s a block element better than using <br>
s, too. :)
Let's make sure to change the selector #bp_group_settings legend
in admin-rtl.css
to .bp-groups-settings-section legend
? (Do we need to touch admin-rtl.css directly anyway? Isn't it generated via the RTL-CSS grunt task?)
#4
@
9 years ago
Thanks @dcavins :) Yes, we do need to reflect style changes in admin-rtl.css
directly as admin CSS is not covered in the RTL-CSS grunt task ... yet. Good spot on the selector. Will commit in a few.
#5
@
9 years ago
- Owner set to mercime
- Resolution set to fixed
- Status changed from new to closed
In 10985:
#7
@
9 years ago
@dcavins @mercime grunt commit
does generate RTL CSS for src/bp-groups/admin/css/admin.css
. Please never edit the RTL CSS directly. As a result of r10985, grunt commit
thinks the RTL CSS has been entered incorrectly: https://gist.github.com/9fe60e61b09dc10f9f3d0d7563c7b815
If your testing has shown your change to be correct, then please edit the CSS file and set up a control directive to tell RTL CSS to not adjust it. Docs here: http://rtlcss.com/learn/usage-guide/control-directives/
Otherwise, we can run grunt commit
and commit the suggested change.
Thanks!
Remove unnecessary unordered list from settings panel. Compensate.