Changeset 10678

Timestamp:

03/23/2016 02:54:39 PM (8 years ago)

Author:

boonebgorges

Message:

Remove markup from translatable strings when building Messages nav items.

Props ramiy.
Fixes #6904.

File:

• trunk/src/bp-messages/classes/class-bp-messages-component.php (modified) (2 diffs)

trunk/src/bp-messages/classes/class-bp-messages-component.php

@@ -150 +150 @@
             $count    = bp_get_total_unread_messages_count();
             $class    = ( 0 === $count ) ? 'no-count' : 'count';
-            $nav_name = sprintf( __( 'Messages <span class="%s">%s</span>', 'buddypress' ), esc_attr( $class ), bp_core_number_format( $count ) );
+            $nav_name = sprintf(
+                /* translators: %s: Unread message count for the current user */
+                __( 'Messages %s', 'buddypress' ),
+                sprintf(
+                    '<span class="%s">%s</span>',
+                    esc_attr( $class ),
+                    bp_core_number_format( $count )
+                )
+            );
         } else {
             $nav_name = __( 'Messages', 'buddypress' );
@@ -240 +248 @@
             $count = messages_get_unread_count();
             if ( !empty( $count ) ) {
-                $title = sprintf( __( 'Messages <span class="count">%s</span>', 'buddypress' ), bp_core_number_format( $count ) );
-                $inbox = sprintf( __( 'Inbox <span class="count">%s</span>',    'buddypress' ), bp_core_number_format( $count ) );
+                $title = sprintf(
+                    /* translators: %s: Unread message count for the current user */
+                    __( 'Messages %s', 'buddypress' ),
+                    '<span class="count">' . bp_core_number_format( $count ) . '</span>'
+                );
+                $inbox = sprintf(
+                    /* translators: %s: Unread message count for the current user */
+                    __( 'Inbox %s', 'buddypress' ),
+                    '<span class="count">' . bp_core_number_format( $count ) . '</span>'
+                );
             } else {
                 $title = __( 'Messages', 'buddypress' );