Changeset 10679

Timestamp:

03/23/2016 03:04:39 PM (8 years ago)

Author:

boonebgorges

Message:

Remove markup from translatable strings when building Group nav items.

Props ramiy.
Fixes #6906.

File:

• trunk/src/bp-groups/classes/class-bp-groups-component.php (modified) (2 diffs)

trunk/src/bp-groups/classes/class-bp-groups-component.php

@@ -436 +436 @@
         // Only grab count if we're on a user page.
         if ( bp_is_user() ) {
-            $class    = ( 0 === groups_total_groups_for_user( bp_displayed_user_id() ) ) ? 'no-count' : 'count';
-            $nav_name = sprintf( _x( 'Groups <span class="%s">%s</span>', 'Group screen nav with counter', 'buddypress' ), esc_attr( $class ), bp_get_total_group_count_for_user() );
+            $class = ( 0 === groups_total_groups_for_user( bp_displayed_user_id() ) ) ? 'no-count' : 'count';
+
+            $nav_name = sprintf(
+                /* translators: %s: Group count for the current user */
+                _x( 'Groups %s', 'Group screen nav with counter', 'buddypress' ),
+                sprintf(
+                    '<span class="%s">%s</span>',
+                    esc_attr( $class ),
+                    bp_get_total_group_count_for_user()
+                )
+            );
         } else {
             $nav_name = _x( 'Groups', 'Group screen nav without counter', 'buddypress' );
@@ -711 +720 @@
 
             if ( ! empty( $count['total'] ) ) {
-                $title   = sprintf( _x( 'Groups <span class="count">%s</span>',          'My Account Groups nav',     'buddypress' ), bp_core_number_format( $count ) );
-                $pending = sprintf( _x( 'Pending Invites <span class="count">%s</span>', 'My Account Groups sub nav', 'buddypress' ), bp_core_number_format( $count ) );
+                $title = sprintf(
+                    /* translators: %s: Group invitation count for the current user */
+                    _x( 'Groups %s', 'My Account Groups nav', 'buddypress' ),
+                    '<span class="count">' . bp_core_number_format( $count ) . '</span>'
+                );
+
+                $pending = sprintf(
+                    /* translators: %s: Group invitation count for the current user */
+                    _x( 'Pending Invites %s', 'My Account Groups sub nav', 'buddypress' ),
+                    '<span class="count">' . bp_core_number_format( $count ) . '</span>'
+                );
             }