Changeset 10555 for trunk/src/bp-friends/classes/class-bp-friends-component.php

Timestamp:

02/08/2016 05:56:22 AM (11 years ago)

Author:

r-a-y

Message:

BP Component: Allow plugins to set a custom position when registering an admin bar subnav menu.

This commit allows plugins to set a 'position' key when registering a WP
Admin Bar subnav menu item in the setup_admin_bar() method.

Previously, plugins had to do all sorts of array shuffling in order to
register their subnav at a preferred position. For backward compatibility,
we do some 'position' key backfilling, so if a plugin isn't using the new
'position' key, their subnav should still display at the same location.

Fixes #6859.

File:

• trunk/src/bp-friends/classes/class-bp-friends-component.php (modified) (1 diff)

trunk/src/bp-friends/classes/class-bp-friends-component.php

@@ -204 +204 @@
                         // My Friends.
                         $wp_admin_nav[] = array(
-                                'parent' => 'my-account-' . $this->id,
-                                'id'     => 'my-account-' . $this->id . '-friendships',
-                                'title'  => _x( 'Friendships', 'My Account Friends menu sub nav', 'buddypress' ),
-                                'href'   => $friends_link
+                                'parent'   => 'my-account-' . $this->id,
+                                'id'       => 'my-account-' . $this->id . '-friendships',
+                                'title'    => _x( 'Friendships', 'My Account Friends menu sub nav', 'buddypress' ),
+                                'href'     => $friends_link,
+                                'position' => 10
                         );
 
                         // Requests.
                         $wp_admin_nav[] = array(
-                                'parent' => 'my-account-' . $this->id,
-                                'id'     => 'my-account-' . $this->id . '-requests',
-                                'title'  => $pending,
-                                'href'   => trailingslashit( $friends_link . 'requests' )
+                                'parent'   => 'my-account-' . $this->id,
+                                'id'       => 'my-account-' . $this->id . '-requests',
+                                'title'    => $pending,
+                                'href'     => trailingslashit( $friends_link . 'requests' ),
+                                'position' => 20
                         );
                 }