Changeset 10553 for trunk/src/bp-blogs/classes/class-bp-blogs-recent-posts-widget.php

Timestamp:

02/08/2016 04:14:59 AM (9 years ago)

Author:

boonebgorges

Message:

Restore template globals after widget loops.

BP template loop functions, like bp_has_members(), are responsible for
populating corresponding template globals. When this happens inside of a
"secondary" loop - such as a sidebar widget - the loop should clean up after
itself by resetting the relevant template global to whatever it previously was
before the secondary loop had run. (This is a rough approximation of WP's
wp_reset_postdata() for BP loops.)

Fixes #5170.

File:

• trunk/src/bp-blogs/classes/class-bp-blogs-recent-posts-widget.php (modified) (3 diffs)

trunk/src/bp-blogs/classes/class-bp-blogs-recent-posts-widget.php

@@ -36 +36 @@
      */
     public function widget( $args, $instance ) {
+        global $activities_template;
 
         $title = ! empty( $instance['title'] )
@@ -75 +76 @@
             'object'     => false,
             'primary_id' => false
-        ); ?>
+        );
+
+        // Back up global.
+        $old_activities_template = $activities_template;
+
+        ?>
 
         <?php if ( bp_has_activities( $args ) ) : ?>
@@ -108 +114 @@
         <?php endif; ?>
 
-        <?php echo $after_widget; ?>
-    <?php
+        <?php echo $after_widget;
+
+        // Restore the global.
+        $activities_template = $old_activities_template;
     }