Changeset 10117 for trunk/src/bp-groups/bp-groups-widgets.php

Timestamp:

09/17/2015 03:59:12 PM (9 years ago)

Author:

mercime

Message:

Groups Widget: Add 'id' attribute to input field and bind to label.

Accessibility fix adds dynamic 'id' value which also replaces the old
'for' value in order to avoid duplicate 'ids' in DOM when more than
one Groups Widget is added to a theme's available widget areas. This
also unwraps the label tag from the select field.

See #6623.

File:

• trunk/src/bp-groups/bp-groups-widgets.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-widgets.php

@@ -180 +180 @@
 
         <p>
-            <label for="bp-groups-widget-groups-default"><?php _e('Default groups to show:', 'buddypress'); ?>
-            <select name="<?php echo $this->get_field_name( 'group_default' ); ?>">
+            <label for="<?php echo $this->get_field_id( 'group_default' ); ?>"><?php _e('Default groups to show:', 'buddypress'); ?></label>
+            <select name="<?php echo $this->get_field_name( 'group_default' ); ?>" id="<?php echo $this->get_field_id( 'group_default' ); ?>">
                 <option value="newest" <?php if ( $group_default == 'newest' ) : ?>selected="selected"<?php endif; ?>><?php _e( 'Newest', 'buddypress' ) ?></option>
                 <option value="active" <?php if ( $group_default == 'active' ) : ?>selected="selected"<?php endif; ?>><?php _e( 'Active', 'buddypress' ) ?></option>
                 <option value="popular"  <?php if ( $group_default == 'popular' ) : ?>selected="selected"<?php endif; ?>><?php _e( 'Popular', 'buddypress' ) ?></option>
             </select>
-            </label>
         </p>
     <?php