Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 15 years ago

#952 closed defect (bug) (fixed)

Group Admin Notifications and more than one private group request

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: 1.1 Priority: major
Severity: Version:
Component: Keywords:
Cc:

Description

Issue described here:
http://buddypress.org/forums/topic/unable-to-authorize-groum-membership-requests

If a private group receives more than one membership request, the group admin user who logs in will see in their "Notifications" menu:

'2 new membership requests for the group ""'

The link for this notification goes nowhere:
hxxp://domain.com/groups//admin/membership-requests/

---

The problem originates in the bp_core_notifications_for_user() function in "bp-core/bp-core-notifications.php".

Tentative fix requires changing these two lines:

$item_id = ( 1 == $action_item_count ) ? $component_action_items[0]->item_id : false;
$secondary_item_id = ( 1 == $action_item_count ) ? $component_action_items[0]->secondary_item_id : false;

to:

$item_id = $component_action_items[0]->item_id;
$secondary_item_id = $component_action_items[0]->secondary_item_id;

---

I don't know why there was a check done for only 1 item and then returning false for more than 1... if a BP dev can explain why, that'd be great.

Change History (1)

#1 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This is fixed in trunk.

Note: See TracTickets for help on using tickets.