Skip to:
Content

BuddyPress.org

Opened 4 weeks ago

Last modified 4 weeks ago

#9324 assigned defect (bug)

"Caps lock is on" warning message and large icon is displayed on registration page

Reported by: emaralive's profile emaralive Owned by: emaralive's profile emaralive
Milestone: 14.5.0 Priority: normal
Severity: normal Version: 14.3.0
Component: Templates Keywords: has-screenshots has-patch 2nd-opinion
Cc:

Description (last modified by emaralive)

Background

WordPress ticket 48345 (Add Caps lock message to login screen) was introduced in milestone 6.9, additionally see PR 8726 which causes a "Caps lock is on" warning message and large icon to be displayed on the BuddyPress registration page when first loaded, see Screenshot - Request-Membership-Git-WP-artifact-01-14-2026_04_03_PM.png.

NOTE: This is only an issue for the BP Nouveau template pack.


In short, the reason for the inadvertent display is that the file that contains the CSS rule, e.g., ‎wp-admin/css/forms.css hasn't been enqueued. The fix is to enqueue the aforementioned CSS file such that the "Caps lock is on" warning message and icon will be displayed as intended for the password input field, see Screenshots - Request-Membership-Git-WP-patched-01-15-2026_10_46_AM.png and Request-Membership-Git-WP-patched-caps-lock-01-15-2026_10_46_AM.png.

I've included two patches, one for trunk and the other for the 14.0 branch.

Attachments (6)

Request-Membership-Git-WP-artifact-01-14-2026_04_03_PM.png (138.5 KB) - added by emaralive 4 weeks ago.
Request-Membership-Git-WP-artifact-01-14-2026_04_03_PM.png
Request-Membership-Git-WP-patched-01-15-2026_10_46_AM.png (114.5 KB) - added by emaralive 4 weeks ago.
Request-Membership-Git-WP-patched-01-15-2026_10_46_AM.png
Request-Membership-Git-WP-patched-caps-lock-01-15-2026_10_46_AM.png (123.8 KB) - added by emaralive 4 weeks ago.
Request-Membership-Git-WP-patched-caps-lock-01-15-2026_10_46_AM.png
9324-trunk-01.diff (709 bytes) - added by emaralive 4 weeks ago.
Initial patch for trunk
9324-14.0-01.diff (709 bytes) - added by emaralive 4 weeks ago.
Initial patch for 14.0 branch
9324-14.0_trunk-01.diff (967 bytes) - added by emaralive 4 weeks ago.
Initial patch for trunk and the 14.0 branch

Download all attachments as: .zip

Change History (12)

@emaralive
4 weeks ago

Request-Membership-Git-WP-artifact-01-14-2026_04_03_PM.png

@emaralive
4 weeks ago

Request-Membership-Git-WP-patched-01-15-2026_10_46_AM.png

@emaralive
4 weeks ago

Request-Membership-Git-WP-patched-caps-lock-01-15-2026_10_46_AM.png

@emaralive
4 weeks ago

Initial patch for trunk

@emaralive
4 weeks ago

Initial patch for 14.0 branch

#1 @emaralive
4 weeks ago

  • Description modified (diff)

#2 @emaralive
4 weeks ago

  • Description modified (diff)

#3 @emaralive
4 weeks ago

  • Description modified (diff)

#4 @johnjamesjacoby
4 weeks ago

In general, we should try to limit our dependency on WordPress core CSS in our themes, and template packs & parts, and I think this is extra important when crossing the admin/theme-side barrier – admin CSS shouldn't be enqueued outside of admin.

Instead of enqueuing forms.css, let's copy the relevant CSS over with any tweaks we think help it look nice?

#5 @emaralive
4 weeks ago

Interesting, so this practice only applies to CSS and not JS? I'm asking because wp/admin/js/user-profile.js is being enqueued here which I took as an example for enqueueing 'forms.css`, meaning it was a wrong inference based off of how JS is implemented.

Additionally, I'm not sure where this is documented and if it is an unwritten rule then it probably should be documented somewhere (other than in a ticket) to spare others from making the same mistake, just saying.

Now that I've been somewhat enlightened, looking at bp-templates/bp-nouveau/css/buddypress.css, I see where there are rules for .register-page .signup-form and, at first glance, it looks like I need to copy over at least 3 rules, so I would think. 🤔

OK, so I'll take another bite at this apple, new patch(es) to come later and thanks for the enlightenment! 😇

#6 @emaralive
4 weeks ago

Round 2

Disregard both of these patches - 9324-trunk-01.diff & 9324-14.0-01.diff, since they are obsolete.

I ended up having to copy a 4th rule due to a sizing issue with the "Caps lock warning" rules and the new proposed patch is: 9324-14.0_trunk-01.diff which works for trunk and the 14.0 branch. Let me know what you think.

@emaralive
4 weeks ago

Initial patch for trunk and the 14.0 branch

Note: See TracTickets for help on using tickets.