bp_get_blog_latest_post not applying filters properly

[shawfactor]

The function

bp_get_blog_latest_post does this on line 763

apply_filters( 'the_title', $retval )

However if you look at the documentation of that filter:

​https://developer.wordpress.org/reference/hooks/the_title/

You will see that the there are two parameters $post_title and $post_id and both are mandatory, so that any plugin that adds this filter and follows the documentation strictly will cause a fatal error

Can this be fixed asap please?

Reported on ​https://buddypress.trac.wordpress.org/ticket/9286, the bp_get_blog_latest_post() will be using the_title filters but only provided 1 out of 2 required params

The patch includes creating new function called bp_get_blog_latest_post_id() which is just a copy of bp_get_blog_latest_post_title(), except it will return latest post ID instead of title.

Then we use this for the required param on the_title filters as per documentation: ​https://developer.wordpress.org/reference/hooks/the_title/

Ticket: ​https://buddypress.trac.wordpress.org/ticket/9286

Filter docs: ​https://developer.wordpress.org/reference/hooks/the_title/

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9286

[espellcaste]

In 14164:

bp_get_blog_latest_post() make use of the the_title filter hook but only one param is provided.

We are introducing two new getters for the latest post ID. bp_get_blog_latest_post_id and bp_blog_latest_post_id.

Developed in ​https://github.com/buddypress/buddypress/pull/411

Props shawfactor, rollybueno, and dcavins.

See #9286 (14.0).

[espellcaste]

In 14165:

bp_get_blog_latest_post() make use of the the_title filter hook but only one param is provided.

We are introducing two new getters for the latest post ID. bp_get_blog_latest_post_id and bp_blog_latest_post_id.

Props shawfactor, rollybueno, and dcavins.

Closes ​https://github.com/buddypress/buddypress/pull/411
Fixes #9286 (trunk)

[espellcaste]

In 14185:

Address a WPCS error for the new bp_get_blog_latest_post_id function.

Introduced at [14165].

See #9286, #9174, and #9173.

[espellcaste]

In 14193:

Address a WPCS error for the new bp_get_blog_latest_post_id function.

Introduced at [14165].

See #9286, #9174, and #9173 (14.0).