Skip to:
Content

BuddyPress.org

Opened 10 months ago

Closed 8 weeks ago

#9280 closed enhancement (fixed)

Typo in filter hook name: friends_activity_friendsip_accepted_action should be friends_activity_friendship_accepted_action

Reported by: khushipatel15's profile khushipatel15 Owned by: espellcaste's profile espellcaste
Milestone: 15.0.0 Priority: normal
Severity: minor Version: 14.3.2
Component: Friends Keywords: has-patch
Cc:

Description

There's a typo in the filter hook name used in the BuddyPress Friends component. The current hook is:
apply_filters( 'friends_activity_friendsip_accepted_action', $action, $friendship );
The word "friendsip" is misspelled and should be "friendship", which could cause issues for developers trying to hook into this filter with the correct spelling.
Since changing a filter hook name can potentially break backward compatibility for developers already using the incorrect one.

Attachments (1)

9280.patch (1.5 KB) - added by khushipatel15 10 months ago.
This patch fixes a typo in the filter hook name used when generating the "friendship accepted" activity action in the BuddyPress Friends component.

Download all attachments as: .zip

Change History (3)

@khushipatel15
10 months ago

This patch fixes a typo in the filter hook name used when generating the "friendship accepted" activity action in the BuddyPress Friends component.

#1 @espellcaste
8 weeks ago

  • Component changed from Core to Friends
  • Milestone changed from Awaiting Review to 15.0.0
  • Owner set to espellcaste
  • Severity changed from normal to minor
  • Status changed from new to assigned

Patch looks look but incomplete. Besides updating the hook name, we will properly deprecate it in 15.0. This is a very old hook from [8125].

#2 @espellcaste
8 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 14163:

Fix a typo in the friends_activity_friendship_accepted_action hook and deprecate it.

Fix a typo in the filter hook name: friends_activity_friendsip_accepted_action which should be friends_activity_friendship_accepted_action.

The hook was also properly deprecated and will be removed in a future release.

Originally at [8125].

Props khushipatel15.

Fixes #9280.

Note: See TracTickets for help on using tickets.