Returns false when it should return an empty array.

[alexanderwbell]

When the activity item was cached and has no comments, we still need to return an empty array, just like how the rest of the function returns an empty array when there are no comments. Other functions depend on this being the case. For example, line 2618 in bp-activity-template.php in the function bp_activity_get_comment_depth will throw an error if this is not the case. We could also set bp_activity_get_comment_depth to check if $comments returned is false in that function and set it to an empty array.

But in this version, we return $comments (which is an empty array) instead of false on line 1649 (I believe) of class-bp-activity-activity.php in the public static function get_activity_comments.

if ( 'none' === $comments_cache ) {

return false;

}
Should I believe be:

if ( 'none' === $comments_cache ) {

return $comments;

}

Or we should check in
bp_activity_get_comment_depth
If the returned $comments is false and set it to an array.

Check github pull request.

​https://buddypress.trac.wordpress.org/ticket/9270#ticket

When the activity item was cached and has no comments, we still need to return an empty array, just like how the rest of the function returns an empty array when there are no comments. Other functions depend on this being the case. For example, line 2618 in bp-activity-template.php in the function bp_activity_get_comment_depth will throw an error if this is not the case. We could also set bp_activity_get_comment_depth to check if $comments returned is false in that function and set it to an empty array.

But in this version, we return $comments (which is an empty array) instead of false on line 1649 (I believe) of class-bp-activity-activity.php in the public static function get_activity_comments.

Trac ticket:

[espellcaste]

This makes sense to me. In the original implementation, the false made sense. See [13312], but the implementation was changed at [13312].

For BP 14.5.0, this should not be an issue since [14149]. So I'll apply this patch to 15.0 only.

[espellcaste]

In 14160:

Return an empty array (instead of false) when BP_Activity_Activity::get_activity_comments has no comments.

Previously, the method would return a boolean false when there was no cached comments. The false had meaning before, see [13312]. But it got changed at [13312].

Props alexanderwbell.

Closes ​https://github.com/buddypress/buddypress/pull/405
Fixes #9270.