Buddypress v14.3.3 does not check if the user_email exists in the signups when creating a new signup

[pratiklondhe]

hi, it seems in the new Buddypress version, the code that checked if the email address exists in a signup or not has been removed causing issue where users are able to signup using same emails multiple times as long as that email is not activated.

svn link for the 14.4.4 tag : ​https://buddypress.trac.wordpress.org/browser/tags/14.3.3/src/bp-members/bp-members-functions.php?rev=14094#L1604

GitHub link where the signup validation does exists:

​https://github.com/buddypress/buddypress/blob/f1bffedb2c7835744169a4623c3955bea6d2796f/src/bp-members/bp-members-functions.php#L1639-L1652

[pratiklondhe]

Replying to pratiklondhe:

hi, it seems in the new Buddypress version, the code that checked if the email address exists in a signup or not has been removed causing issue where users are able to signup using same emails multiple times as long as that email is not activated.

svn link for the 14.4.4 tag : ​https://buddypress.trac.wordpress.org/browser/tags/14.3.3/src/bp-members/bp-members-functions.php?rev=14094#L1604

GitHub link where the signup validation does exists:

​https://github.com/buddypress/buddypress/blob/f1bffedb2c7835744169a4623c3955bea6d2796f/src/bp-members/bp-members-functions.php#L1639-L1652

correction: the svn link is for 14.3.3v tag

[espellcaste]

duplicate of #9137

[pratiklondhe]

Replying to espellcaste:

duplicate of #9137

may I know where is this fixed?

[espellcaste]

@pratiklondhe This is fixed in 15, at #9137, at [14071] it won't be ported back to legacy versions.

[pratiklondhe]

Replying to espellcaste:

@pratiklondhe This is fixed in 15, at #9137, at [14071] it won't be ported back to legacy versions.

so in the next release right ?
any idea why this was removed in the first place as I am able to see it being there earlier but later removed.

[espellcaste]

@pratiklondhe The github link you pointed to goes to trunk, this [one ​https://buddypress.trac.wordpress.org/browser/tags/14.3.3/src/bp-members/bp-members-functions.php?rev=14094#L1604] goes to the 14.3.3 version. It doesn't have that code yet.

I'm not sure if you saw it in trunk and incorrectly assumed it was available before, because as far as I know, this issue always existed before it was patched.

[pratiklondhe]

Replying to espellcaste:

@pratiklondhe The github link you pointed to goes to trunk, this ​one goes to the 14.3.3 version. It doesn't have that code yet.

I'm not sure if you saw it in trunk and incorrectly assumed it was available before, because as far as I know, this issue always existed before it was patched.

• ahh got it, I assumed wrong, thanks for being patient with this!