page_on_front dropdown on secondary sites includes items from root site

[boonebgorges]

Setup:

• Multisite
• BP 14.1.0, activated networkwide
• BP Classic 1.4.0, activated networkwide

When visiting Dashboard > Settings > Reading on a secondary site (ie not the root blog), the page_on_front dropdown includes the bp_pages items from the root blog.

Related: #9052

Seems like we should simply be bailing out of the function (or not hooking the callback to 'get_pages' at all) when ! bp_is_root_blog(), but happy to hear other ideas.

[vapvarun]

Attaching a patch that implements the suggested fix - bailing out of bp_core_include_directory_on_front() when not on the root blog.

The Change:

// BP pages are only relevant on the root blog in multisite.
if ( ! bp_is_root_blog() ) {
    return $pages;
}

This check is added right after the existing query parser check, so on secondary sites in multisite, the function returns early and doesn't add BP directory pages to the page_on_front dropdown.

Testing (subdirectory multisite):

=== ROOT BLOG (site 1) ===
bp_is_root_blog(): true
Homepage dropdown options: Activity, Groups, Members, Sample Page, Sites

=== SECONDARY SITE ===
bp_is_root_blog(): false
Homepage dropdown options: Sample Page (only)

Verified in browser - BP pages from the root site no longer appear in the Settings > Reading > Homepage dropdown on secondary sites.

[espellcaste]

Moving this to 14.5 since it is a small fix. I was able to confirm it too. Good catch.

[espellcaste]

One minor correction in my testing. This issue would never happen with "BP Classic 1.4.0, activated networkwide". Since bp_core_get_query_parser returns rewrites. So my guess is @boonebgorges that this plugin is inactive for you? That's a typo, right?!

[espellcaste]

In 14183:

Stop (root blog) BuddyPress directories from showing in the WP Dropdown pages control.

BuddyPress appends its directories to the WP Dropdown pages control. However, secondary sites can not use BuddyPress directories as their front-end pages.

Props boonebgorges and vapvarun.

Fixes #9259 (trunk)

[espellcaste]

This went to 14 as part of [14182]. But due to a typo in my message, it got committed but without its full commit message.