Skip to:
Content

BuddyPress.org

Opened 13 months ago

Closed 13 months ago

#9258 closed defect (bug) (fixed)

Resolve BP Legacy activity heartbeat anomaly for private groups

Reported by: emaralive's profile emaralive Owned by: emaralive's profile emaralive
Milestone: 14.3.0 Priority: normal
Severity: normal Version: 14.2.1
Component: Templates Keywords: has-screenshots has-patch dev-feedback
Cc:

Description

See #9248 & 14062 for original details. This anomaly is specific to:

  • Active template pack: BP Legacy
  • URL Parser: BP Rewrites API
  • Private Groups

See screenshot for a visual of the anomaly. This ticket was created so that the proposed patch (derived from the fix for #9248) can be applied to the 14.0 branch.

Attachments (2)

bp-legacy-heartbeat-anomaly.png​ (267.6 KB) - added by emaralive 13 months ago.
Screenshot of anomaly
9258.01.patch​ (4.1 KB) - added by emaralive 13 months ago.
Initial patch

Download all attachments as: .zip

Change History (8)

@emaralive
13 months ago

Screenshot of anomaly

@emaralive
13 months ago

Initial patch

This ticket was mentioned in ​Slack in #buddypress by emaralive. ​View the logs.
13 months ago

#2 follow-up: @dcavins
13 months ago

Is 9258.01.patch exactly the same change as ​https://buddypress.trac.wordpress.org/changeset/14062?

Thanks!

#3 in reply to: ↑ 2 @emaralive
13 months ago

Replying to dcavins:

Is 9258.01.patch exactly the same change as ​https://buddypress.trac.wordpress.org/changeset/14062?

Thanks!

As far as I can tell, it is. The patch was from ​https://patch-diff.githubusercontent.com/raw/buddypress/buddypress/pull/393.patch, which was from the ​PR 393, I just used a --no-prefix flag to generate the 9258.01.patch.

Additionally, I tested it and it has the same behavior as with #9248. Are you seeing differences?

#4 @emaralive
13 months ago

Additional info:

The local repo is a clone from git://buddypress.git.wordpress.org/

  • switched to the 14.0 branch
  • applied the patch made from PR 393, i.e., patch -p1 < /path/to/patch, since there was a prefix.
  • ran the command git diff --no-prefix and it looked as expected
  • did a before (anomaly is present) and after test (anomaly resolved), which is the same behavior as with trunk for the after test.
  • created patch via git diff --no-prefix > /path/to/patch
  • changed name of patch to 9258.01.patch and attached same to this ticket.

So yeah, I'm pretty sure the changes are in line with 14062.

Last edited 13 months ago by emaralive (previous) (diff)

This ticket was mentioned in ​Slack in #buddypress by emaralive. ​View the logs.
13 months ago

#6 @dcavins
13 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Resolved in #9248.

Note: See TracTickets for help on using tickets.