Skip to:
Content

BuddyPress.org

Opened 13 months ago

Closed 13 months ago

#9251 closed task (fixed)

Failing test with WordPress trunk

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 15.0.0 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch has-unit-tests
Cc:

Description

Let's investigate why BP_Tests_Core_Functions::test_bp_attachments_get_allowed_types is now failing

Change History (3)

#1 @imath
13 months ago

Reason is: ​https://core.trac.wordpress.org/changeset/59315

That being said, the current test needs to be reviewed as it doesn't make sense to test bp_attachments_get_allowed_types() for image types adding a trailing slash so that it doesn't fall into the BuddyPress supported image types.

This ticket was mentioned in ​PR #401 on ​buddypress/buddypress by ​@imath.
13 months ago #2

  • Keywords has-patch has-unit-tests added

Test document types instead of image ones as BP image supported types are not the same than WordPress.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9251

#3 @imath
13 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 14067:

PHPUnit tests: improve the bp_attachments_get_allowed_types() test

Use a more meaningful test checking for document file types.

Fixes #9251
Closes ​https://github.com/buddypress/buddypress/pull/401

Note: See TracTickets for help on using tickets.