Skip to:
Content

BuddyPress.org

Opened 5 months ago

Closed 3 months ago

#9228 closed enhancement (fixed)

Blogs: `blog_id` is accepted in the `bp_get_blog_avatar`, regardless if there is a blog in the current loop

Reported by: espellcaste's profile espellcaste Owned by: espellcaste's profile espellcaste
Milestone: 15.0.0 Priority: normal
Severity: normal Version:
Component: Blogs Keywords: has-patch
Cc:

Description

bp_get_blog_avatar accepts a blog_id argument that only works if there is a blog in the current loop.

IMO, we should respect if the blog_id is passed, regardless if there is a blog in the current loop.

Currently, it's not possible to pass another, different blog_id into bp_get_blog_avatar inside a blog loop because of the current logic.

Change History (4)

This ticket was mentioned in ​PR #398 on ​buddypress/buddypress by ​renatonascalves.
3 months ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9228

#2 @espellcaste
3 months ago

  • Keywords has-patch has-unit-tests removed
  • Milestone changed from Awaiting Review to 15.0.0

#3 @espellcaste
3 months ago

  • Keywords has-patch added

#4 @espellcaste
3 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 14072:

Blogs: blog_id is accepted in the bp_get_blog_avatar, regardless if there is a blog in the current loop.

Props imath.

Closes ​https://github.com/buddypress/buddypress/pull/398
Fixes #9228

Note: See TracTickets for help on using tickets.