Skip to:
Content

BuddyPress.org

Opened 6 weeks ago

Closed 2 weeks ago

Last modified 2 weeks ago

#9184 closed defect (bug) (fixed)

Missing admin-menu separator when bbPress is active

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 14.0.0 Priority: normal
Severity: normal Version: 5.0.0
Component: Administration Keywords: has-screenshots commit
Cc:

Description

When bbPress is active, and when BuddyPress is Network Activated, the "Email" top-level menu-item gets grouped together with bbPress' menu items.

Attachments (3)

jjj-2024-06-13-at-17-42-55-UTC@2x.png (45.4 KB) - added by johnjamesjacoby 6 weeks ago.
What it's like now…
jjj-2024-06-13-at-18-08-59-UTC@2x.png (58.5 KB) - added by johnjamesjacoby 6 weeks ago.
What it should be…
9184.diff (2.3 KB) - added by johnjamesjacoby 6 weeks ago.

Download all attachments as: .zip

Change History (9)

@johnjamesjacoby
6 weeks ago

What it's like now...

@johnjamesjacoby
6 weeks ago

What it should be...

#1 @johnjamesjacoby
6 weeks ago

I think the faulty logic is, conveniently, inside of the bp_admin_separator() function itself.

It does not have any accommodations for what's happening inside of BP_Core::register_post_types().

(Tangentially, there is a code comment from myself (from r6845) that eludes this being a potential problem in the future due to a lack of an API at the time.)

#2 @johnjamesjacoby
6 weeks ago

  • Milestone changed from Up Next to 12.6.0

@johnjamesjacoby
6 weeks ago

#3 @imath
6 weeks ago

  • Keywords commit added; 2nd-opinion removed

Looks good to me @johnjamesjacoby thanks a lot for catching & fixing it 👍

#4 @imath
2 weeks ago

  • Milestone changed from 12.6.0 to 14.0.0

As 14.0.0 is planned to July 12, we'll probably won't need 12.6, I'm moving this ticket in 14.0.0 to fix it there & in trunk.

#5 @imath
2 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13955:

Avoid the BP Email menu to be grouped with bbPress menu items

In multisite configs & when BuddyPress is network activated, make sure to add an admin menu separator before the BP Email menu in the site admin menu so that it is not grouped with another plugin's admin menu items.

Props johnjamesjacoby

Fixes #9184

#6 @imath
2 weeks ago

In 13956:

Avoid the BP Email menu to be grouped with bbPress menu items

In multisite configs & when BuddyPress is network activated, make sure to add an admin menu separator before the BP Email menu in the site admin menu so that it is not grouped with another plugin's admin menu items.

Props johnjamesjacoby

See #9184 (branch 14.0)

Note: See TracTickets for help on using tickets.