Missing admin-menu separator when bbPress is active

[johnjamesjacoby]

When bbPress is active, and when BuddyPress is Network Activated, the "Email" top-level menu-item gets grouped together with bbPress' menu items.

[johnjamesjacoby]

What it's like now...

[johnjamesjacoby]

What it should be...

[johnjamesjacoby]

I think the faulty logic is, conveniently, inside of the bp_admin_separator() function itself.

It does not have any accommodations for what's happening inside of BP_Core::register_post_types().

(Tangentially, there is a code comment from myself (from r6845) that eludes this being a potential problem in the future due to a lack of an API at the time.)

[imath]

Looks good to me @johnjamesjacoby thanks a lot for catching & fixing it 👍

[imath]

As 14.0.0 is planned to July 12, we'll probably won't need 12.6, I'm moving this ticket in 14.0.0 to fix it there & in trunk.

[imath]

In 13955:

Avoid the BP Email menu to be grouped with bbPress menu items

In multisite configs & when BuddyPress is network activated, make sure to add an admin menu separator before the BP Email menu in the site admin menu so that it is not grouped with another plugin's admin menu items.

Props johnjamesjacoby

Fixes #9184

[imath]

In 13956:

Avoid the BP Email menu to be grouped with bbPress menu items

In multisite configs & when BuddyPress is network activated, make sure to add an admin menu separator before the BP Email menu in the site admin menu so that it is not grouped with another plugin's admin menu items.

Props johnjamesjacoby

See #9184 (branch 14.0)