Unable to send "0" in messages through REST API

[niftythree]

Hello,

We've found that the REST API cannot send 0 (i.e. the digit for zero) as the only content for a message. This applies to messages in both new and existing threads (see first screenshot). However, it will accept other variations. E.g. 00; 01; 10; etc. as the only content of a message, and it doesn't appear to be an issue for any other numbers/digits (see second screenshot).

We've tested all of the above with the following set-up:
WordPress version: 6.5.3
BuddyPress version: 12.5.0
BuddyPress Template: Legacy
Theme: Twenty Twenty-Four
Plugins active: BuddyPress, JSON Basic Authentication (​https://github.com/WP-API/Basic-Auth)
PHP: 7.4

Thanks.

[espellcaste]

That's a good catch, actually.

In PHP, empty("0") returns true while empty("00") does not. I can update this to better check what's truly empty.

[niftythree]

Thanks @espellcaste; we appreciate it being updated and the context you've provided.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9175

[emaralive]

@espellcaste are the unit tests sufficient to move this ticket & associated PR along or do we also need to manually test the change in ​PR 330 in conjunction with ​PR 511?

[espellcaste]

In 13986:

Allow creating messages with non-empty content.

Use of the PHP empty function to check if the message content is empty is not ideal when creating a message. Update the logic to consider any string as non-empty.

Props emaralive, niftythree.

See #9175
Closes ​https://github.com/buddypress/buddypress/pull/330

[espellcaste]

@emaralive The code from the REST API will be bundled with #9145, since we will add a V2. I'll keep this ticket open until we introduce it. :)