Opened 3 months ago
Last modified 5 days ago
#9174 assigned task
WPCS improvements for 15.0
Reported by: | espellcaste | Owned by: | espellcaste |
---|---|---|---|
Milestone: | 15.0.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | has-patch |
Cc: |
Description
Previously:
- #7228 (<14.0)
Change History (16)
#3
@
3 months ago
For those, I opted just to use "object" rather than the exact class names, because they're lengthy & ugly & make the docs more difficult to read. Feel free to override that decision later!
I'm not opposed to this change but two arguments for adding the object class is IDE support (intelephense) and it makes more clearer about its value.
In a IDE, like vscode, one can't go to that particular class anymore, since it is an anonymous object
. One can't also tell what's the object real class, which properties this object support, if it does.
Essentially, one loses intelephense support, which is helpful while developing and we would be documenting the variable's true value.
If the $global
value accepts both an anonymous object
and BP_Optouts_List_Table
, I'd advocate adding both there.
docs more difficult to read
I'd argue it makes it lenthy, not difficult to read. But I'd accept this is just my opinion.
This ticket was mentioned in PR #331 on buddypress/buddypress by renatonascalves.
2 months ago
#6
- Keywords has-patch added
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9174
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9173
This ticket was mentioned in Slack in #buddypress by espellcaste. View the logs.
7 weeks ago
This ticket was mentioned in PR #365 on buddypress/buddypress by renatonascalves.
12 days ago
#13
As titled.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9174
This ticket was mentioned in PR #366 on buddypress/buddypress by renatonascalves.
12 days ago
#14
Apply phpcbf
to the activity
component so that we can fix automatic styling issues in bulk.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9174
In 13927: