Skip to:
Content

BuddyPress.org

Opened 3 months ago

Closed 2 months ago

#9135 closed defect (bug) (fixed)

Error on the Accept Invitation Button for Private Group (Groups Directory)

Reported by: kainelabsteam's profile kainelabsteam Owned by: imath's profile imath
Milestone: 14.0.0 Priority: normal
Severity: normal Version: 12.4.0
Component: Groups Keywords: has-patch
Cc:

Description

Good Day,

I would to report a bug that we can replicate on our staging website. To reproduce it, kindly do these steps:

  1. Create a Private Group, and then send an invitation to your friend
  2. Login with an account where the invitation sent
  3. Go to the Groups Directory page
  4. Click the "Accept Invitation" button

And you will see this error:

https://ibb.co/8Dqq3Pz

This error happens both with legacy and Nouveau themes.

Thank you for your time, and please let me know if you already released a patch to fix this.

Best Regards,

Attachments (1)

Untitled.jpg (17.0 KB) - added by kainelabsteam 3 months ago.

Download all attachments as: .zip

Change History (8)

#1 @kainelabsteam
3 months ago

  • Component changed from Core to Groups
  • Milestone changed from Up Next to Awaiting Review

#2 @imath
3 months ago

  • Milestone changed from Awaiting Review to 14.0.0
  • Priority changed from high to normal

Hi @kainelabsteam

Thanks a lot for your report. I confirm the issue. Accepting an invite from the user's groups invitations screen works as expected, but doing so from the Groups directory is not.

#3 @kainelabsteam
3 months ago

Hi @imath

Thank you very much for your prompt response and reviewing our report.

Best Regards,

#4 @kainelabsteam
3 months ago

Dear BuddyPress Team.

Is there any estimation of when you will release the patch regarding this issue?

Thank you for your time.

Best Regards,

This ticket was mentioned in PR #285 on buddypress/buddypress by imath.


3 months ago
#5

  • Keywords has-patch added; needs-patch removed

Unless an Administrator is viewing another member's group invitations screen, the right user ID to use is the logged in user ID.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9135

dcavins commented on PR #285:


2 months ago
#6

Your fix looks good to me! I agree that it should nearly always be the logged-in user's ID, with the very unusual exception that an admin is helping another user accept an invite, which you've covered.

#7 @imath
2 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13862:

BP Nouveau: use the right user ID to accept a group invite

The displayed user ID should only be used when an administrator is viewing a user profile. In all other contexts, the logged in user ID needs to be used. This change is fixing the issue when accepting such an invite from the groups directory.

Props kainelabsteam, dcavins

Fixes #9135
Closes https://github.com/buddypress/buddypress/pull/285

Note: See TracTickets for help on using tickets.