Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#911 closed defect (bug) (fixed)

Deleted/Replied to message fix

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.1 Priority: critical
Severity: Version:
Component: Keywords: has-patch
Cc:

Description

Patch to fix situation where a user deletes a message, and someone in the tread replies to it. Previously the message/thread was never unmarked as deleted. This patch fixes it quite easily.

Situation


Burt = user_id 3
John = user_id 2
Andy = user_id 1

Before


  1. I message Andy and Burt.
  2. I delete message in my sent box. (user_id = 2; is_deleted = 1)
  3. Burt reads the message, and deletes (user_id = 3; is_deleted = 1)
  4. Andy messages us back.
  5. Message never shows up in my inbox. is_deleted still = 1
  6. Message never shows up in Burt's inbox. is_deleted still = 1

After


  1. I message Andy.
  2. I delete message in my sent box. (user_id = 2; is_deleted = 1)
  3. Burt reads the message, and deletes (user_id = 3; is_deleted = 1)
  4. Andy messages us back. (user_id = 3,2; is_deleted = 0)
  5. Burt and I both receive notifications of new messages and all is well.

Patch attached.

Attachments (1)

911-jjj.patch (847 bytes) - added by johnjamesjacoby 13 years ago.
BP_Messages_Message::send fix

Download all attachments as: .zip

Change History (3)

@johnjamesjacoby
13 years ago

BP_Messages_Message::send fix

#1 @DJPaul
13 years ago

  • Milestone changed from 1.0.4 to 1.1

You, Sir, are a genius.

#2 @apeatling
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1689]) Fixes #911 props jjj.

Note: See TracTickets for help on using tickets.