Update email address verify link not working

[yagniksangani]

I wanted to change or update my email address in my account. So I added a new email address and then received a verify new email address link in the mail inbox.

So when I clicked on the verify link, it was not working and the email address was not updated. I checked it in the latest version of the plugin right now "12.2.0" and many other old versions. So all the past few versions have the same issue.

I debugged the Buddypress plugin code and found the issue, the verify link has been created wrong.
In the file "/buddypress/bp-settings/actions/general.php" the verify link generation code is wrong, "bp_displayed_user_url( $path_chunks )" ​https://snipboard.io/A8cGeC.jpg and verify link does not redirect to "settings" page.

The correct code should be, ​https://snipboard.io/fu5ydw.jpg
"bp_displayed_user_url( bp_members_get_path_chunks( $path_chunks ) )"
So now the verify link redirects to the "settings/" page and the new email address gets verified successfully.

So please fix this issue as soon as in the next release. So in the next plugin update, it will be resolved on my websites. For now, I temporarily fixed in my website's plugin file.

This is a major issue missed by the Buddypress plugin team for since long time and from many last releases, no one faced that within the buddypress team.

I faced the issue and resolved the issue as well, So would you like to appreciate me, with some kind of a gift/money?

Thanks

[imath]

Hi @yagniksangani

It will be fixed shortly in next minor release. It’s a régression introduced in last major release (12.0).

The BP Core team is maintaining the plugin freely and we do not have a reward program. As it’s open source everyone is welcome to contribute.

We had a 5 months beta period asking plugin, theme developers as well as regular users to alert us about potential issues. The one you reported today wasn’t into these beta reports.

Only security issues are rewarded from WordPress h1 bug bounty program, see ​https://hackerone.com/wordpress

[yagniksangani]

@imath ok, hope that the next minor release is available soon.

[dcavins]

Hi @yagniksangani, thanks for finding this problem and offering a solution to it! Yep, there's no pay in open source, but we're all contributing to make something better which we can all use and enjoy. Thanks for your contribution!

Make sure the email verification link is generated the right way

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9106

[imath]

In 13733:

Settings: generate the email verification link the right way

Props yagniksangani

See #9106 (trunk)
Closes ​https://github.com/buddypress/buddypress/pull/236

[imath]

In 13734:

Settings: generate the email verification link the right way

Props yagniksangani

Fixes #9106 (branch 12.0)