Forum Link in Group-Nav even when enable_forum=false

[bigbozo]

We found that a group despite having no forum attached shows a link to forum nonetheless.
When called The title of an random? existing forum is displayed, interaction is not possible.

We circumvented the problem by writing a childtemplate for wp-content/plugins/buddypress/bp-templates/bp-nouveau/buddypress/groups/single/parts/item-nav.php checking if a forum is attached and subsequently suppressing the link-output.

<?php
...
        while ( bp_nouveau_nav_items()) :
                bp_nouveau_nav_item();
                        ?>
                <?php
                /**
                 * Patch to suppress link to forum if not exist
                 */
                        if ('bp_group_read_forum' === bp_nouveau()->current_nav_item['rewrite_id'] &&
                            false == buddypress()->groups->current_group->enable_forum) {
                            continue;
                        }
                ?>
...

After intensive debugging we found that when \BBP_Forums_Group_Extension::maybe_unset_forum_menu is called bp_is_group() returns false.

Later the line \BP_Groups_Component::parse_query:1074 gets executed; after that bp_is_group() correctly returns true.

[imath]

Hi,

Thanks for your feedback @bigbozo I confirm the issue, so far the bbPress plugin is not ready yet for BP 12.0.0. Installing and activating BP Classic should fix this issue, but another one will subsist about pagination. I will soon package BP Classic 1.4.0 to fix it.

The real fix will be to make bbPress fully compatible with BP 12.0 & up and this will happen when this ticket will be resolved:
​https://bbpress.trac.wordpress.org/ticket/3576