Skip to:
Content

BuddyPress.org

Opened 2 months ago

Closed 2 months ago

#9095 closed defect (bug) (fixed)

Use BP Rewrites API for Customizer BP Member Nav Items

Reported by: vapvarun's profile vapvarun Owned by: imath's profile imath
Milestone: 12.3.0 Priority: normal
Severity: normal Version: 12.0.0
Component: Templates Keywords: has-patch
Cc:

Description

We need to update bp_nouveau_member_customizer_nav() to the BP Rewrites API.

reported by @nitinp544 on slack

bp_get_component_navigations() can be used

A similar issue was already resolved here https://buddypress.trac.wordpress.org/ticket/8971

Attachments (1)

image (45).png (100.1 KB) - added by vapvarun 2 months ago.
Inside Customizer Member Primary Link Reorder Options are missing

Download all attachments as: .zip

Change History (6)

@vapvarun
2 months ago

Inside Customizer Member Primary Link Reorder Options are missing

#1 @imath
2 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 12.3.0

Hi @vapvarun thanks for your report. You’re right, we’ll have it fixed asap.

#2 @imath
2 months ago

  • Component changed from Navigation to Templates
  • Version set to 12.0.0

This ticket was mentioned in PR #230 on buddypress/buddypress by imath.


2 months ago
#3

  • Keywords has-patch added; needs-patch removed

Fixes a notice error about the Group's customizer panel to customize nav item orders
Brings back the nav items to the Member's customizer panel to allow the admin to customize the order for these.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9095

#4 @imath
2 months ago

In 13726:

BP Nouveau: repair the customizer panel to sort Members nav items

Changes introduced by the BP Rewrites API about how the Members nav items are registered and then set up generated a regression about this customizer panel.

In short, the bp_parse_query action is not fired while building the customizer's panels.

To bring back the possibility to sort the Members nav items from the BP Nouveau > Members Navigation panel, we now need to force the generation of the primary nav using the bp_get_component_navigations() function.

NB: this commit also prevents a notice error when sanitizing the navigation setting to sort items.

Props nitinp544, vapvarun

See #9095 (trunk)
Closes https://github.com/buddypress/buddypress/pull/230

#5 @imath
2 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13727:

BP Nouveau: repair the customizer panel to sort Members nav items

Changes introduced by the BP Rewrites API about how the Members nav items are registered and then set up generated a regression about this customizer panel.

In short, the bp_parse_query action is not fired while building the customizer's panels.

To bring back the possibility to sort the Members nav items from the BP Nouveau > Members Navigation panel, we now need to force the generation of the primary nav using the bp_get_component_navigations() function.

NB: this commit also prevents a notice error when sanitizing the navigation setting to sort items.

Props nitinp544, vapvarun

Fixes #9095 (branch 12.0)

Note: See TracTickets for help on using tickets.