Opened 9 months ago
Closed 9 months ago
#9094 closed defect (bug) (fixed)
Every click on Load more "eats" some posts.
Reported by: | testovac | Owned by: | imath |
---|---|---|---|
Milestone: | 12.3.0 | Priority: | omg pizza |
Severity: | normal | Version: | 11.0.0 |
Component: | Activity | Keywords: | has-patch has-unit-tests |
Cc: |
Description
Every click on Load more "eats" some posts. All the content I have in the database will never be shown. Access to activities as a single page works.
tested on two different themes (buddyx and twenty twenty one)
I click the load more button for the first time, the posts are loaded but the first one in the order is missing.
I click the load more button a second time, and there are many missing.
Same for other clicks.
Attachments (1)
Change History (9)
#1
@
9 months ago
- Keywords needs-patch added
- Milestone set to 12.3.0
- Version changed from 12.2.0 to 11.0.0
#3
@
9 months ago
Hello @imath
am not have checked Activity auto-refresh: https://buddypress.trac.wordpress.org/attachment/ticket/9094/admin%20bp.jpeg
#4
follow-up:
↓ 6
@
9 months ago
Sure, it's there anyway even if this option is not active. This is to avoid duplicates if someone posted an update just before you clicked on the load more button. I've found a fix. I'll submit a PR asap.
This ticket was mentioned in PR #229 on buddypress/buddypress by imath.
9 months ago
#5
- Keywords has-patch has-unit-tests added; needs-patch needs-unit-tests removed
The offset lower value needs to remain the higher activity ID of the first displayed page.
Include two unit tests about offset_lower
filter usage.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9094
#6
in reply to:
↑ 4
@
9 months ago
- Priority changed from strategic to omg pizza
Replying to imath: :-) thx
Sure, it's there anyway even if this option is not active. This is to avoid duplicates if someone posted an update just before you clicked on the load more button. I've found a fix. I'll submit a PR asap.
Hi @testovac
Thanks a lot for your report. I confirm the issue. I believe it's a regression introduced by [13344] where we wanted to avoid duplicates when the Activity Auto Refresh option is active.
It's a pretty nasty one, reason why I want to fix it asap in next minor release, even if it's not due to changes added in branch 12.0.