Skip to:
Content

BuddyPress.org

Opened 4 months ago

Last modified 4 months ago

#9092 assigned defect (bug)

Member type have no default title

Reported by: 1naveengiri's profile 1naveengiri Owned by: espellcaste's profile espellcaste
Milestone: Up Next Priority: normal
Severity: normal Version: 7.0.0
Component: Members Keywords: has-patch
Cc:

Description

I have added a member type with just Slug and no name.
https://ibb.co/dPYLtG2

After this, I found an empty checkbox with no default title.
https://ibb.co/XLx1jn9

In my opinion, it should either say (no name) or it should use the member type slug as the name of the membership type.


Attachments (10)

Screenshot 2024-02-10 at 10.03.33 PM.png (223.5 KB) - added by 1naveengiri 4 months ago.
member type with no name
Screenshot 2024-02-10 at 10.02.48 PM.png (230.6 KB) - added by 1naveengiri 4 months ago.
Empty checkbox for member type
member-type-required.png (54.0 KB) - added by imranmd 4 months ago.
Add required label on all three fileds.
singular-name-required-message.png (59.3 KB) - added by imranmd 4 months ago.
Add message for singular name required field.
plural-name-required-message.png (59.0 KB) - added by imranmd 4 months ago.
Add message for plural name required field.
9092.patch (4.1 KB) - added by imranmd 4 months ago.
patch added
group-type-required.png (58.0 KB) - added by imranmd 4 months ago.
Add required label on all three fields for group.
group-singular-name-required-message.png (64.1 KB) - added by imranmd 4 months ago.
Add message for singular name required field for group.
group-plural-name-required-message.png (63.6 KB) - added by imranmd 4 months ago.
Add message for plural name required field for group.
9092.2.patch (5.6 KB) - added by imranmd 4 months ago.
patch added

Download all attachments as: .zip

Change History (16)

@1naveengiri
4 months ago

member type with no name

@1naveengiri
4 months ago

Empty checkbox for member type

#1 @imath
4 months ago

  • Component changed from Extended Profile to Members
  • Milestone changed from Awaiting Review to 14.0.0
  • Version changed from 12.2.0 to 7.0.0

Hi @1naveengiri

Thanks for you report. We'll fix it soon.

@imranmd
4 months ago

Add required label on all three fileds.

@imranmd
4 months ago

Add message for singular name required field.

@imranmd
4 months ago

Add message for plural name required field.

@imranmd
4 months ago

patch added

#2 @imranmd
4 months ago

  • Keywords needs-patch removed

@imath I have checked above mentioned issue. I made the singular and plural name fields required to resolve this issue and added patch. Also, I have attached screenshot after resolved this issue.

#3 @imath
4 months ago

  • Keywords has-patch added

Thanks e lot for your patch @imranmd

I believe some functions are used for both Group and Member types. This one in particular: bp_core_admin_insert_type(). That's probably the reason why "Type" was used instead of "Member type". Could you test adding a group type to see if your patch doesn't introduce a side effect there?

@imranmd
4 months ago

Add required label on all three fields for group.

@imranmd
4 months ago

Add message for singular name required field for group.

@imranmd
4 months ago

Add message for plural name required field for group.

@imranmd
4 months ago

patch added

#4 @imranmd
4 months ago

Hi @imath,

Apologies for the oversight. I initially checked only for the member type. However, in my new patch, I've included code for both member and group types.

This ticket was mentioned in Slack in #buddypress by espellcaste. View the logs.


4 months ago

#6 @espellcaste
4 months ago

  • Milestone changed from 14.0.0 to Up Next
  • Owner set to espellcaste
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.