Member type have no default title

[1naveengiri]

I have added a member type with just Slug and no name.

After this, I found an empty checkbox with no default title.

In my opinion, it should either say (no name) or it should use the member type slug as the name of the membership type.

[1naveengiri]

member type with no name

[1naveengiri]

Empty checkbox for member type

[imath]

Hi @1naveengiri

Thanks for you report. We'll fix it soon.

[imranmd]

Add required label on all three fileds.

[imranmd]

Add message for singular name required field.

[imranmd]

Add message for plural name required field.

[imranmd]

patch added

[imranmd]

@imath I have checked above mentioned issue. I made the singular and plural name fields required to resolve this issue and added patch. Also, I have attached screenshot after resolved this issue.

[imath]

Thanks e lot for your patch @imranmd

I believe some functions are used for both Group and Member types. This one in particular: bp_core_admin_insert_type(). That's probably the reason why "Type" was used instead of "Member type". Could you test adding a group type to see if your patch doesn't introduce a side effect there?

[imranmd]

Add required label on all three fields for group.

[imranmd]

Add message for singular name required field for group.

[imranmd]

Add message for plural name required field for group.

[imranmd]

patch added

[imranmd]

Hi @imath,

Apologies for the oversight. I initially checked only for the member type. However, in my new patch, I've included code for both member and group types.

[espellcaste]

@imranmd I can confirm your bug report. I'll test your suggested patch.

[imranmd]

Thank you @espellcaste

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9092

[espellcaste]

Tested the patch. Good addition. Added here: ​https://github.com/buddypress/buddypress/pull/335

[imranmd]

Thanks @espellcaste

[espellcaste]

In 13983:

Require singular and plural names for BuddyPress custom types.

When creating a member or group type, require that both singular and plural names are provided. This ensures that the type can be properly registered and used throughout BuddyPress.

Props 1naveengiri, imath, imranmd.

Fixes #9092
Closes ​https://github.com/buddypress/buddypress/pull/335/