Skip to:
Content

BuddyPress.org

Opened 8 months ago

Closed 8 months ago

#9082 closed defect (bug) (fixed)

Activity single page with plain permalinks is endlessly redirecting the user

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 12.3.0 Priority: normal
Severity: normal Version: 12.0.0
Component: Activity Keywords: has-patch
Cc:

Description

As shared by @johnjamesjacoby into our Slack channel:
https://wordpress.slack.com/archives/C02RQBYUG/p1705982391019319

The root of the issue seems to be located in this part of the code:
https://github.com/buddypress/buddypress/blob/master/src/bp-activity/screens/permalink.php#L66|L70

My guess is: when plain permalinks are on, BP action ( p ) and BP action variables ( array( $activity_id ) ) are query vars coming from the click on a single activity link. These are wrongly added to the redirect link.

Change History (4)

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


8 months ago

This ticket was mentioned in PR #225 on buddypress/buddypress by @imath.


8 months ago
#2

  • Keywords has-patch added; needs-patch removed

Remove potential BP URI query variables from activity permalink when redirecting to the activity single screen.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9082

#3 @imath
8 months ago

In 13714:

Ensure single activity permalink router is reliable with plain links

When building the URL to redirect a single activity request to the member's activity single view, make sure to remove potential BP URI query variables relative to the Activity component before trying to transport extra query variables to the redirect URL.

Props johnjamesjacoby

See #9082
Closes https://github.com/buddypress/buddypress/pull/225

#4 @imath
8 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13715:

Ensure single activity permalink router is reliable with plain links

When building the URL to redirect a single activity request to the member's activity single view, make sure to remove potential BP URI query variables relative to the Activity component before trying to transport extra query variables to the redirect URL.

Props johnjamesjacoby

Fixes #9082 (branch 12.0)

Note: See TracTickets for help on using tickets.