Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 22 months ago

#9081 closed enhancement (fixed)

BuddyPress Unit Tests: review our tests

Reported by: espellcaste's profile espellcaste Owned by: espellcaste's profile espellcaste
Milestone: 15.0.0 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch has-unit-tests
Cc:

Description

BuddyPress Unit Tests: review our tests and make sure they are up to the mark.

Change History (12)

#1 @espellcaste
2 years ago

  • Owner set to espellcaste
  • Status changed from new to assigned

#2 @espellcaste
2 years ago

  • Milestone changed from Awaiting Review to Up Next

Will review this next cycle.

This ticket was mentioned in ​PR #295 on ​buddypress/buddypress by ​renatonascalves.
2 years ago #3

  • Keywords has-patch has-unit-tests added

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9081

​imath commented on ​PR #295:
2 years ago #4

Amazing @renatonascalves !!! I'll try to review it asap. Do you plan to include it into the 14.0 milestone? I'm asking because it's currently set to up next on Trac.

​renatonascalves commented on ​PR #295:
2 years ago #5

@imath If it's approved, sure. We can also delay, no hurry.

​dcavins commented on ​PR #295:
2 years ago #6

Wow! Does this win the award for most extensive patch ever? :)

​renatonascalves commented on ​PR #295:
2 years ago #7

Considering the loc, ​this one is bigger.

#8 @imath
23 months ago

  • Milestone changed from Up Next to 15.0.0

#9 @espellcaste
23 months ago

  • Type changed from defect (bug) to enhancement

#10 @espellcaste
22 months ago

@imath Any objections to the changes suggested here: ​https://github.com/buddypress/buddypress/pull/295

#11 @imath
22 months ago

@espellcaste I just reviewed the PR, it's fine with me: thanks again for these improvements 💪

#12 @espellcaste
22 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13980:

Unit Tests: Conducted a thorough review of existing unit tests files and improved them to ensure robustness.

Props imath.

Closes ​https://github.com/buddypress/buddypress/pull/295
Fixes #9081

Note: See TracTickets for help on using tickets.