Skip to:
Content

BuddyPress.org

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#9070 closed defect (bug) (fixed)

who's online widget - name of logged in user missing after hover over profile picture

Reported by: jnie's profile jnie Owned by: imath's profile imath
Milestone: 12.2.0 Priority: normal
Severity: normal Version: 12.0.0
Component: Members Keywords: needs-testing has-patch
Cc:

Description

Hi,

before buddypress 12.0.0 the profile picture was rotated and the name of the logged in user was shown above the profile picture when hovering over a logged in user of the "Who's online" widget. The Element 'a.bp-tooltip:hover::after' within the Element 'div.item-avatar' should show the name of the user which is currently online (name of user is content of class 'data-bp-tooltip').

Since buddypress 12.0.0 I have the issue that displaying the name of the logged in user after hovering over the profile picture only works on the pages which got associated with buddypress component directory (Settings -> Buddypress -> Pages) which are the activity feed page and the members page. On all my other pages within my site the name of the logged in user (Element 'a.bp-tooltip:hover::after') isn't shown the way I described before.

Things I already tried:

  • clearing cache
  • re-installing latest wordpress version (6.4.2)
  • re-installing latest version of my theme (woffice)
  • deactivating all plugins
  • using different browsers

Change History (9)

#1 @imath
3 months ago

  • Milestone changed from Awaiting Review to 12.1.0

Hi @jnie

Thanks for your report, if you are talking about Legacy widgets, these were moved into the BP Classic Add-on.

But I think it has more to do with the fact we are no more loading our Scripts and CSS everywhere on the site compared to what we were doing previously. I’ll look at it also in BuddyPress but for Block widgets.

You can fix it right away (waiting for a next minor release) using the following filter:

add_filter( 'bp_enqueue_assets_in_bp_pages_only', '__return_false' );

#2 @jnie
3 months ago

Hi @imath

Thanks for the quick reply! The filter you've sent worked perfectly.

I will leave your filter embedded on my site till the next minor release of buddypress.

#3 @imath
3 months ago

It will be fixed in BP Classic 1.3.0 for Legacy Widgets:
See: https://github.com/buddypress/bp-classic/pull/36

I'll need more time to fix Block Widgets in BuddyPress (trunk & branch 12.0)

#4 @imath
3 months ago

  • Milestone changed from 12.1.0 to 12.2.0

#5 @imath
3 months ago

After looking more into it: the bp-tooltip css rules should be moved into a specific CSS file so that it can be added as a dependency to Block Widgets styles & BP Classic Legacy Widgets styles.

This ticket was mentioned in PR #221 on buddypress/buddypress by @imath.


3 months ago
#6

  • Keywords has-patch added; needs-patch removed
  1. Move BP Tooltips default CSS rules into a Core file usable with or without Template pack assets.
  2. Use this core file as a dependency for Admin's common CSS.
  3. Enqueue BP Tooltips CSS rules when Block widgets are rendered.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9070

#7 @imath
3 months ago

In 13709:

Create a specific CSS file for BP Tooltips

  • Move BP Tooltips default CSS rules into their own BP Core file so that it's easier to add this file as a style dependency.
  • Let BP Template Packs override this BP Core file and create a new bp-tooltips.css file into BP Nouveau to do so.
  • Use this BP Core file as a dependency to Admin's Hello styles as well as BP Template packs main styles.
  • Enqueue BP Tooltips CSS rules when Block widgets are rendered.

Props jnie

See #9070 (trunk)
Closes https://github.com/buddypress/buddypress/pull/221

#8 @imath
3 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13710:

Create a specific CSS file for BP Tooltips

  • Move BP Tooltips default CSS rules into their own BP Core file so that it's easier to add this file as a style dependency.
  • Let BP Template Packs override this BP Core file and create a new bp-tooltips.css file into BP Nouveau to do so.
  • Use this BP Core file as a dependency to Admin's Hello styles as well as BP Template packs main styles.
  • Enqueue BP Tooltips CSS rules when Block widgets are rendered.

Props jnie

Fixes #9070 (branch 12.0)

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


3 months ago

Note: See TracTickets for help on using tickets.