bp_rewrites_get_url filter is not supplied original function arguments

[sjregan]

For the bp_rewrites_get_url() function, an optional list of arguments can be provided to the function for determining what URL will be built.

At the end of the function, the resulting URL is filtering using the bp_rewrites_get_url filter. The filter is supplied with a modified version of the function arguments rather than the original function arguments.

This means when filtering the URL critical fields such as 'component_id' are not passed to the filter.

Seen in v12 through v14-alpha.

…r (fixes #9060)

The bp_rewrites_get_url() function passes function arguments after they have been modified by the function. This fix ensures the original function arguments are passed to the filter so critical fields remain intact.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9060#ticket

Hi @sjregan Thanks for your contribution. Patch is looking good after a quick look. I'll check it more deeply.

[imath]

In 13691:

Improve the 'bp_rewrites_get_url' filter additional parameters

• Make sure the first additional parameter $path_chunks contains an unchanged & parsed version of the function original arguments.
• Add a second additional parameter $args containing the function original arguments.

Props sjregan

Fixes #9060
Closes ​https://github.com/buddypress/buddypress/pull/213