Skip to:
Content

BuddyPress.org

Opened 13 months ago

Closed 12 months ago

#9001 closed defect (bug) (fixed)

Members listing page shows wrong active members counter

Reported by: diabolique's profile Diabolique Owned by: imath's profile imath
Milestone: 12.0.0 Priority: normal
Severity: normal Version: 10.0.0
Component: Core Keywords: has-patch
Cc:

Description

Hello,

When you are on the mambers listing page - (​https://domainname.com/members/) there is a counter of active members. When you enter the page it shows correct number but instantly some javascript action switches it to the number of users which are actually on the page, for example if there is 20 users per page then it shows 20 number, if there are 5 members per page then it shows 5 number instead of showing total count.

Attachments (1)

Screenshot 2023-10-05 at 21-39-59 Members.png​ (14.1 KB) - added by Diabolique 13 months ago.

Download all attachments as: .zip

Change History (6)

@Diabolique
13 months ago

#1 @dontdream
13 months ago

For completeness, this happens with the Nouveau template pack, not with Legacy.

#2 @imath
12 months ago

Thanks for your report @Diabolique

I'll look at it asap. I'm a bit surprised it doesn't take the total active members count, I'm the one who added the JavaScript 😅

Version 0, edited 12 months ago by imath (next)

#3 @imath
12 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 12.0.0
  • Version changed from 11.3.1 to 10.0.0

I confirm the issue, working on a fix.

This ticket was mentioned in ​PR #173 on ​buddypress/buddypress by ​@imath.
12 months ago #4

  • Keywords has-patch added; needs-patch removed

In ​[13136] I've haven't used the right property to get the total member count. The member_count property in informing about the number of displayed members, the total_member_count is the right property to use.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9001

#5 @imath
12 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13593:

BP Nouveau: use the right count for the Members dynamic directory tab

In [13136] the $member_count property was wrongly used to inform about the total member count. $member_count is informing about the number of displayed members. The $total_member_count property is the right one to use.

Props Diabolique

Fixes #9001
Closes ​https://github.com/buddypress/buddypress/pull/173

Note: See TracTickets for help on using tickets.