Skip to:
Content

BuddyPress.org

Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#8996 closed task (fixed)

`BP_Members_Component::check_parsed_query()` needs an improvement

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 12.0.0 Priority: normal
Severity: normal Version:
Component: Members Keywords: has-patch
Cc:

Description

Checking for Component Classes sub_nav property isn't enough, some plugins can add custom sub nav items to an existing component. A check using the Members' component nav should also be performed.

Change History (3)

This ticket was mentioned in ​PR #166 on ​buddypress/buddypress by ​@imath.
13 months ago #1

  • Keywords has-patch added; needs-patch removed

Make sure to check for nav items added from outside component classes.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8996

#2 @imath
13 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13583:

Improve BP_Members_Component::check_parsed_query()

As some sub nav items can be added to an existing component by third party plugin authors, checking for an existing and valid screen function from the component's sub_nav property is not enough. We also need to do the same check using The Member's component secondary navigation object.

Fixes #8996
Closes ​https://github.com/buddypress/buddypress/pull/166

This ticket was mentioned in ​Slack in #buddypress by imath. ​View the logs.
13 months ago

Note: See TracTickets for help on using tickets.