Skip to:
Content

BuddyPress.org

Opened 10 months ago

Closed 10 months ago

Last modified 9 months ago

#8962 closed defect (bug) (fixed)

The latest Activities block generates a fatal in BP Default

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 11.3.0 Priority: high
Severity: major Version:
Component: Activity Keywords: has-patch
Cc:

Description

Testing BP Default I've noticed that only checking for the bp_get_theme_compat_id() is not enough to be sure 'Nouveau' is fully loaded. When a standalone BP Theme is active the bp_get_theme_compat_id() is set, an additional check needs to be done on bp_is_theme_compat_active()

Attachments (1)

8962-branch-11-0.patch (503 bytes) - added by imath 10 months ago.

Download all attachments as: .zip

Change History (6)

This ticket was mentioned in PR #146 on buddypress/buddypress by @imath.


10 months ago
#1

  • Keywords has-patch added; needs-patch removed

Check theme compat is active before using bp_nouveau()

Trac ticket: https://buddypress.trac.wordpress.org/ticket/8962

#3 @imath
10 months ago

In 13537:

BP Blocks: make sure theme compat is active before using a TP function

When a BuddyPress standalone theme is active (eg: BP Default) the bp_get_theme_compat_id() returns the ID of the active template pack (TP) (eg: "nouveau"), but it doesn't mean the corresponding template pack code is loaded, to be sure of it we need to use bp_is_theme_compat_active().

See #8962 (trunk)
Closes https://github.com/buddypress/buddypress/pull/146

#4 @imath
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13538:

BP Blocks: make sure theme compat is active before using a TP function

When a BuddyPress standalone theme is active (eg: BP Default) the bp_get_theme_compat_id() returns the ID of the active template pack (TP) (eg: "nouveau"), but it doesn't mean the corresponding template pack code is loaded, to be sure of it we need to use bp_is_theme_compat_active().

Fixes #8962 (branch 11.0)

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


9 months ago

Note: See TracTickets for help on using tickets.