Skip to:
Content

BuddyPress.org

Opened 11 months ago

Closed 9 months ago

Last modified 3 weeks ago

#8959 closed task (fixed)

The URLs BP Settings page needs an help page

Reported by: imath's profile imath Owned by: dcavins's profile dcavins
Milestone: 12.0.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords:
Cc:

Description

Unlike what we used to do for the Pages association settings screen, some quick explanations about this Administration screen would be great.

Attachments (2)

8959.1.patch (2.6 KB) - added by dcavins 9 months ago.
Add help content to the URL settings screen
8959.2.patch (5.9 KB) - added by imath 9 months ago.

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


9 months ago

This ticket was mentioned in PR #167 on buddypress/buddypress by @imath.


9 months ago
#2

  • Keywords has-patch added; needs-patch removed
  • Use a redirect to be sure to clear notice errors when a required field is missing.
  • Preserve submitted texts and contacts in case of missing required fields.
  • Improve the feedback message so that it informs about all missing required fields.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/8959

#3 @imath
9 months ago

  • Keywords needs-patch added; has-patch removed

Ouch! Sorry I made a mistake, the above PR is about #8578

@dcavins
9 months ago

Add help content to the URL settings screen

#4 @dcavins
9 months ago

  • Owner set to dcavins
  • Status changed from new to assigned

@imath I've added a patch above. Please let me know if the internationalization for this section looks right to you or if it should be organized/formatted differently. Thanks!

@imath
9 months ago

#5 @imath
9 months ago

  • Keywords has-patch commit added; needs-patch removed

Hi @dcavins

Thanks a lot! It Looks good, I'm just feeling bad leaving unescaped strings, so I suggested a few changes in .2.patch.

+ I don't think we need a link to the codex for Rewrites

I was thinking we should probably have a central place to list all these help links so that it will be easier to change these when needed (<- but that's probably out of the scope of this ticket).

Feel free to commit !

#6 @dcavins
9 months ago

  • Keywords has-patch commit removed
  • Resolution set to fixed
  • Status changed from assigned to closed

Ugh, I typoed the trac ticket:
In 13586:

(The changeset message doesn't reference this ticket)

Note: See TracTickets for help on using tickets.