Skip to:
Content

BuddyPress.org

#8940 closed defect (bug) (fixed)

Make sure the way the single group canonical stack is set is right

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 12.0.0 Priority: high
Severity: major Version:
Component: Groups Keywords: has-patch
Cc:

Description

Working on making bbPress ready for the BP Rewrites API, I've noticed a misuse of the bp_groups_get_path_chunks() function when setting the action_variables key of the group's canonical stack.

As the URL chunks were missing the current action, one of the action variables was wrongly removed, the single view of a topic was wrongly redirected to an URL missing the topic URL chunk before the subject of the topic.

A PR will follow to fix this annoying issue.

Change History (2)

This ticket was mentioned in PR #134 on buddypress/buddypress by @imath.


12 months ago
#1

  • Keywords has-patch added; needs-patch removed

If the manage context does not need the current action to get the customized slugs for action variables, the read context does.

Moreover, as the current group is not set during the creation process, we don't need to get customized action variables for the create context.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/8940

#2 @imath
12 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13521:

Ensure the way the single group canonical stack is set is consistent

If the manage context does not need the current action to get the customized slugs for action variables, the read context does.

Moreover, as the current group is not set during the creation process, we don't need to get customized action variables for the create context.

Fixes #8940
See #4954
Closes https://github.com/buddypress/buddypress/pull/134

Note: See TracTickets for help on using tickets.