Warning: Attempt to read property in bp-core-buddybar.php

[corzel]

BuddyPress 11.2.0, WordPress 6.2.2, BP Theme Legacy, PHP 8.1.18

Warning: Attempt to read property "link" on null in /*/public_html/wp-content/plugins/buddypress/bp-core/bp-core-buddybar.php on line 370

Warning: Attempt to read property "slug" on null in /*/public_html/wp-content/plugins/buddypress/bp-core/bp-core-buddybar.php on line 370

[imath]

+ bp_core_new_nav_default() should be checked when using the BP Rewrites API.

[imath]

This bug revealed a more severe issue with the BP Rewrites API when plain permalinks are used. In this case we absolutely need to set the buddypress()->unfiltered_uri global according to the $GLOBALS['wp']->query_string instead of the $GLOBALS['wp']->request, otherwise bp_core_new_nav_default() redirects all sub navs to the default one.

• In case plain permalinks are used, use the $GLOBALS['wp']->query_string to set the buddypress()->unfiltered_uri global.
• No need to edit sub nav links when calling bp_core_new_nav_default() if the URL parser is set to 'rewrites' (default one since 12.0.0).
• Finally reply to the original issue raised by the contributor making sure to avoid a notice if the new subnav object misses the slug and/or the link properties.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8936

[imath]

In 13519:

Make sure bp_core_new_nav_default() is ready for the BP Rewrites API

• In case plain permalinks are used, use the $GLOBALS['wp']->query_string to set the buddypress()->unfiltered_uri global.
• Do not edit sub nav links when calling bp_core_new_nav_default() if the URL parser is set to 'rewrites'.
• Avoid a PHP notice if the new sub nav object misses the slug and/or the link properties.

Props corzel

See #4954
Fixes #8936
Closes ​https://github.com/buddypress/buddypress/pull/130