#8927 closed task (fixed)
Fully deprecate `bp_nav` & `bp_options_nav` BP globals
Reported by: | imath | Owned by: | imath |
---|---|---|---|
Milestone: | 12.0.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | has-patch has-unit-tests |
Cc: |
Description
These 2 backward compatibility globals are deprecated since BuddyPress 2.6, let's fully deprecate them and move the backward compatibility mechanism into the BP Classic plugin.
Change History (4)
This ticket was mentioned in PR #121 on buddypress/buddypress by @imath.
16 months ago
#1
- Keywords has-patch has-unit-tests added; needs-patch removed
16 months ago
#3
A little clarification please, Would bp_setup_nav action hook still work ? bp_core_new_nav_item would work on bp_setup_nav hook ?
16 months ago
#4
Hi @MrVibe
Sure see https://github.com/buddypress/buddypress/blob/58f2e85dfc2608c2e6934f5ece63e64d7cfe7e7c/src/bp-core/bp-core-buddybar.php#L39 & https://github.com/buddypress/buddypress/blob/58f2e85dfc2608c2e6934f5ece63e64d7cfe7e7c/src/bp-core/bp-core-dependency.php#L184
I just moved very old deprecated code (since 2.3) inside BP Classic plugin.
Let's move the code and corresponding Unit tests into the BP Classic plugin.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/8927