Skip to:
Content

BuddyPress.org

Opened 9 months ago

Last modified 7 months ago

#8915 new defect (bug)

More Top Margin in Responsive design

Reported by: pitamdey's profile pitamdey Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: BuddyPress.org Sites Priority: lowest
Severity: normal Version:
Component: BuddyPress.org Sites Keywords: has-screenshots has-patch
Cc:

Description

URL : https://buddypress.org/
The Recent Topics Section has a larger top margin under screen size 780px

Attachments (4)

Screenshot 2023-06-03 at 4.55.03 PM.png (191.2 KB) - added by pitamdey 9 months ago.
Screenshot for better understanding
8915.patch (4.2 KB) - added by pitamdey 9 months ago.
After applying this solution the issue resolved
8915.1.patch (486 bytes) - added by nidhidhandhukiya 9 months ago.
Hello @pitamdey
8915.1.2.patch (486 bytes) - added by nidhidhandhukiya 9 months ago.
Hello @pitamdey, your patch resolve the issue, but this main id is present in whole buddypress site, if we applied your patch it will remove the spacing in other pages too, so I have attached the patch which targets the #main only of the homepage.

Download all attachments as: .zip

Change History (9)

@pitamdey
9 months ago

Screenshot for better understanding

@pitamdey
9 months ago

After applying this solution the issue resolved

#1 @imath
9 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to BuddyPress.org Sites

@nidhidhandhukiya
9 months ago

Hello @pitamdey

@nidhidhandhukiya
9 months ago

Hello @pitamdey, your patch resolve the issue, but this main id is present in whole buddypress site, if we applied your patch it will remove the spacing in other pages too, so I have attached the patch which targets the #main only of the homepage.

#2 @pitamdey
9 months ago

Thanks @nidhidhandhukiya

#3 follow-up: @krupalpanchal
9 months ago

Hi There,

8915.1.2.patch LGTM.

There is also a padding used for the #main div. So we should also consider that and add margin to only left and right.

body.home-page #main{
	margin: 0 10px;
}

Let's see someone else's feedback on this.

#4 in reply to: ↑ 3 @huzaifaalmesbah
7 months ago

Thanks to krupalpanchal:

body.home-page #main{
margin: 0 10px;
}

I think this is a good solution.

#5 @huzaifaalmesbah
7 months ago

Do you have any thoughts about this? @imath

Note: See TracTickets for help on using tickets.