Skip to:
Content

BuddyPress.org

Opened 4 months ago

Last modified 4 months ago

#8913 new defect (bug)

Check PHPcs Coding standard

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Up Next Priority: normal
Severity: normal Version:
Component: Extended Profile Keywords: has-patch
Cc:

Description

Hello Team,

I have reviewed the code and found PHPcs errors & warnings in some of the files:

Here, I mentioned all those files:

/src/bp-xprofile/bp-xprofile-filters.php
/src/bp-xprofile/bp-xprofile-cssjs.php
/src/bp-xprofile/bp-xprofile-caps.php
/src/bp-xprofile/classes/class-bp-xprofile-field.php
/src/bp-xprofile/classes/class-bp-xprofile-field-type-checkbox.php

Thanks,

Attachments (7)

8913.patch (7.3 KB) - added by viralsampat 4 months ago.
I have checked above mentioned issue and resolved few errors and warning. Here, I have added its patch.
8913.2.patch (8.1 KB) - added by viralsampat 3 months ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
8913.3.patch (8.1 KB) - added by viralsampat 2 months ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
8913.4.patch (5.6 KB) - added by viralsampat 2 months ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
8913.5.patch (3.6 KB) - added by viralsampat 2 months ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
8913.6.patch (9.1 KB) - added by viralsampat 7 weeks ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
8913.7.patch (1.9 KB) - added by viralsampat 7 weeks ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.

Download all attachments as: .zip

Change History (8)

@viralsampat
4 months ago

I have checked above mentioned issue and resolved few errors and warning. Here, I have added its patch.

#1 @imath
4 months ago

  • Component changed from Core to Extended Profile
  • Keywords has-patch added; needs-patch reporter-feedback dev-feedback removed
  • Milestone changed from Awaiting Review to Up Next

Thanks for your ticket & patch. As we're doing a lot of changes in 12.0, I prefer to delay things about WP code standards to next milestone.

@viralsampat
3 months ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

@viralsampat
2 months ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

@viralsampat
2 months ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

@viralsampat
2 months ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

@viralsampat
7 weeks ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

@viralsampat
7 weeks ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

Note: See TracTickets for help on using tickets.