Skip to:
Content

BuddyPress.org

Opened 11 months ago

Closed 2 months ago

#8913 closed defect (bug) (maybelater)

Check PHPcs Coding standard

Reported by: viralsampat's profile viralsampat Owned by: espellcaste's profile espellcaste
Milestone: Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Cc:

Description

Hello Team,

I have reviewed the code and found PHPcs errors & warnings in some of the files:

Here, I mentioned all those files:

/src/bp-xprofile/bp-xprofile-filters.php
/src/bp-xprofile/bp-xprofile-cssjs.php
/src/bp-xprofile/bp-xprofile-caps.php
/src/bp-xprofile/classes/class-bp-xprofile-field.php
/src/bp-xprofile/classes/class-bp-xprofile-field-type-checkbox.php

Thanks,

Attachments (7)

8913.patch (7.3 KB) - added by viralsampat 11 months ago.
I have checked above mentioned issue and resolved few errors and warning. Here, I have added its patch.
8913.2.patch (8.1 KB) - added by viralsampat 10 months ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
8913.3.patch (8.1 KB) - added by viralsampat 9 months ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
8913.4.patch (5.6 KB) - added by viralsampat 9 months ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
8913.5.patch (3.6 KB) - added by viralsampat 9 months ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
8913.6.patch (9.1 KB) - added by viralsampat 9 months ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
8913.7.patch (1.9 KB) - added by viralsampat 9 months ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.

Download all attachments as: .zip

Change History (12)

@viralsampat
11 months ago

I have checked above mentioned issue and resolved few errors and warning. Here, I have added its patch.

#1 @imath
11 months ago

  • Component changed from Core to Extended Profile
  • Keywords has-patch added; needs-patch reporter-feedback dev-feedback removed
  • Milestone changed from Awaiting Review to Up Next

Thanks for your ticket & patch. As we're doing a lot of changes in 12.0, I prefer to delay things about WP code standards to next milestone.

@viralsampat
10 months ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

@viralsampat
9 months ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

@viralsampat
9 months ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

@viralsampat
9 months ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

@viralsampat
9 months ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

@viralsampat
9 months ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

#2 @imath
5 months ago

  • Milestone changed from Up Next to 14.0.0

#3 @espellcaste
4 months ago

  • Component changed from Extended Profile to Build/Test Tools
  • Owner set to netweb

#4 @espellcaste
2 months ago

  • Owner changed from netweb to espellcaste
  • Status changed from new to accepted

#5 @espellcaste
2 months ago

  • Milestone 14.0.0 deleted
  • Resolution set to maybelater
  • Status changed from accepted to closed

So, I have plans to update this in a better way. Making it easier to code review via github. So, I'm going to resolve this and handle those updates in the next milestone.

I also tried to apply those patches but patch -p failed. Not sure why.

Note: See TracTickets for help on using tickets.