Opened 17 months ago
Closed 9 months ago
#8913 closed defect (bug) (maybelater)
Check PHPcs Coding standard
Reported by: | viralsampat | Owned by: | espellcaste |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch |
Cc: |
Description
Hello Team,
I have reviewed the code and found PHPcs errors & warnings in some of the files:
Here, I mentioned all those files:
/src/bp-xprofile/bp-xprofile-filters.php
/src/bp-xprofile/bp-xprofile-cssjs.php
/src/bp-xprofile/bp-xprofile-caps.php
/src/bp-xprofile/classes/class-bp-xprofile-field.php
/src/bp-xprofile/classes/class-bp-xprofile-field-type-checkbox.php
Thanks,
Attachments (7)
Change History (12)
#1
@
17 months ago
- Component changed from Core to Extended Profile
- Keywords has-patch added; needs-patch reporter-feedback dev-feedback removed
- Milestone changed from Awaiting Review to Up Next
Thanks for your ticket & patch. As we're doing a lot of changes in 12.0, I prefer to delay things about WP code standards to next milestone.
@
17 months ago
I have checked above mentioned issue and founds few files. Here, I have added its patch.
@
16 months ago
I have checked above mentioned issue and founds few more files. I have applied its patch.
@
16 months ago
I have checked above mentioned issue and founds few more files. I have applied its patch.
@
16 months ago
I have checked above mentioned issue and founds few more files. I have applied its patch.
@
15 months ago
I have checked above mentioned issue and founds few more files. I have applied its patch.
@
15 months ago
I have checked above mentioned issue and founds few more files. I have applied its patch.
#5
@
9 months ago
- Milestone 14.0.0 deleted
- Resolution set to maybelater
- Status changed from accepted to closed
So, I have plans to update this in a better way. Making it easier to code review via github. So, I'm going to resolve this and handle those updates in the next milestone.
I also tried to apply those patches but patch -p
failed. Not sure why.
I have checked above mentioned issue and resolved few errors and warning. Here, I have added its patch.