Opened 17 months ago
Closed 17 months ago
#8908 closed defect (bug) (fixed)
Do not neutralize `BP_Component::parse_query()` when BP Rewrites are not in use
Reported by: | imath | Owned by: | imath |
---|---|---|---|
Milestone: | 12.0.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Route Parser | Keywords: | has-patch |
Cc: |
Description
Even if we were not using it until 12.0, only using BP_Component::parse_query()
when BP Rewrites can generate issues with plugins which were using WP Rewrites to build their URLs. For example, the BP Attachments plugin does.
To prevent resetting BP URI globals another time when the Legacy URL parser is used (having the BP Classic plugin active), we need to neutralize each children component's parse_query()
methods.
Relative to #4954
Change History (2)
Note: See
TracTickets for help on using
tickets.
Make sure
BP_Component::parse_query()
always run. Only running when BP Rewrites are on is not the right way to go as some plugins might have been using WP Rewrites API for a while and might be extending this method from their component's class.Trac ticket: https://buddypress.trac.wordpress.org/ticket/8908