Opened 17 months ago
Closed 14 months ago
#8890 closed defect (bug) (fixed)
Docs: Improve various globals documentation, as per docblock standards.
Reported by: | upadalavipul | Owned by: | imath |
---|---|---|---|
Milestone: | 12.0.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | (not sure) | Keywords: | has-patch |
Cc: |
Description
Function commenting details needs to improve.
Files:
- src/bp-xprofile/classes/class-bp-xprofile-group.php
- src/bp-xprofile/classes/class-bp-xprofile-meta-query.php
- src/bp-xprofile/classes/class-bp-xprofile-profiledata.php
- src/bp-xprofile/classes/class-bp-xprofile-query.php
Attachments (22)
Change History (37)
#2
@
16 months ago
- Owner set to imath
- Resolution set to fixed
- Status changed from new to closed
In 13475:
#3
@
16 months ago
- Component changed from Core to Extended Profile
- Keywords commit removed
- Resolution fixed deleted
- Status changed from closed to reopened
@
16 months ago
I have checked above mentioned issue and founds few files. Here, I have added its patch.
@
16 months ago
I have checked above mentioned issue and founds few files. Here, I have added its patch.
@
16 months ago
I have checked above mentioned issue and founds few files. Here, I have added its patch.
#5
@
16 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Hi @viralsampat
Thanks a lot for these 3 new patches. I'll review it asap.
#6
@
16 months ago
Hi @viralsampat
For your next contributions, could you use the --no-prefix
option when saving your diffs. Thanks in advance 🙏.
I'll commit the inline doc improvements shortly.
@
16 months ago
I have checked above mentioned issue and founds few files. Here, I have added its patch.
@
16 months ago
I have checked above mentioned issue and founds few files. Here, I have added its patch.
#8
@
16 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Hi thanks for the patch @viralsampat as I've requested in comment:6 using the --no-prefix
option would have save us some more time, please consider using it for your next patches. By the way, you can include more than one file into your patches.
#9
@
16 months ago
- Keywords needs-refresh added
Also, please use the BuddyPress trunk version to build your diffs, bp_core_set_uri_globals()
is deprecated and is no more in src/bp-core/bp-core-catchuri.php
meaning this patch is outdated.
@
16 months ago
I have checked above mentioned issue and founds few files. Here, I have added its patch.
#10
@
16 months ago
- Keywords needs-refresh removed
Thanks for the refresh I will check the patch and commit changes asap.
@
16 months ago
I have checked above mentioned issue and founds few files. Here, I have added its patch.
#12
@
16 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Hi @viralsampat Thanks a lot for this new patch. I will review & commit it asap.
@
16 months ago
I have checked above mentioned issue and founds few files. Here, I have added its patch.
@
16 months ago
I have checked above mentioned issue and founds few files. Here, I have added its patch.
Hi @upadalavipul
Thanks for your contribution, patch looks good 👍. I will commit it shortly.