Skip to:
Content

Opened 10 years ago

Closed 9 years ago

#888 closed defect (bug) (no action required)

"Send Invites" submit button needs pretty button css look. "generic-button" like css needed.

Reported by: r-a-y Owned by: Jason_JM
Milestone: 1.1 Priority: trivial
Severity: Version:
Component: Keywords: Send Invite, button, submit, style, css, has-patch, needs-testing
Cc: Jason_JM

Description

When using the default bpmember theme, on the Groups > Send Invites page, the "Send Invites" button is missing the "generic-button" class, so the button looks off-kilter.

In BP 1.0.3 - /bp-groups/bp-groups-templatetags.php, change line 1537 from:

					<div class="action">

to:

<div class="generic-button action">

Attachments (2)

(JASON_JM)(BP)screen.css_ticket-888(v1).patch (864 bytes) - added by Jason_JM 9 years ago.
(JASON_JM)(BP)send-invite_ticket-888(v1).patch (1.1 KB) - added by Jason_JM 9 years ago.
V1 of patch for ticket #888. File 2/2.

Download all attachments as: .zip

Change History (12)

#1 @apeatling
10 years ago

  • Milestone changed from 1.0.4 to 1.1

Milestone 1.0.4 deleted

#2 @Jason_JM
10 years ago

  • Cc Jason_JM added
  • Keywords Send Invite button submit style needs-patch added
  • Type changed from defect to enhancement

This is going to be a little different for the new theme I think. The nice button styles have not been applied yet for this guy.

If I have time I'll assign this to myself.

Might need to play with a custom class.

Parent container will need generic-button
Child (submit button) will need border:none, and the right arrow.
I actually have done this, but i'm running out of time atm. I'll get to it soon :-)

#3 @Jason_JM
10 years ago

  • Owner set to Jason_JM
  • Status changed from new to assigned

#4 @Jason_JM
10 years ago

  • Keywords css added
  • Summary changed from "generic-button" CSS class not in "Send Invites" button to "Send Invites" submit button needs pretty button css look. "generic-button" like css needed.

#5 @Jason_JM
10 years ago

btw, this ticket been sittin around for 2 months! Dang!

#6 @apeatling
9 years ago

  • Type changed from enhancement to defect

#7 @Jason_JM
9 years ago

patch coming in a bit

@Jason_JM
9 years ago

V1 of patch for ticket #888. File 2/2.

#8 @Jason_JM
9 years ago

My patches need testing.
They were written in a static environment (no access to one for a few hours).

#9 @Jason_JM
9 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#10 @apeatling
9 years ago

  • Resolution set to invalid
  • Status changed from assigned to closed

I don't think this is needed, the send invites button looks fine to me. Thanks for the patch in any case.

Note: See TracTickets for help on using tickets.