Unable to reply to messages via links in email notifications

[dave.pullig]

This is a follow-up to #8825.

When replying to a message thread when you have followed a link from an email notification, it's not possible to send the reply - the following is logged in the the browser's console when the "Send reply" button is clicked:

Uncaught TypeError: e.has is not a function
buddypress-messages.min.js?ver=11.1.0:1 
 
    at n.sendReply (buddypress-messages.min.js?ver=11.1.0:1:22353)
    at HTMLDivElement.dispatch (jquery.min.js?ver=3.6.3:2:43184)
    at y.handle (jquery.min.js?ver=3.6.3:2:41168)

It's also possible to replicate this by refreshing the page having opened it from the inbox view, or by pasting the URL into the browser.

I've replicated this on a clean site with just BuddyPress & Twenty TwentyThree.

[imath]

Hi @davepullig

Thanks for your report, I’ll look at it asap.

[dave.pullig]

Thanks @imath, happy to help test any patches.

• Make sure the send action can get the Thread ID if the thread view was generated by opening the inbox view or thanks to the BackBone Router (direct URL access).
• Make sure the Thread data used by the Thread's header is initialized as a BackBone Model.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8870

[imath]

Awesome, I believe the above PR is fixing this issue.

[dave.pullig]

Yes, that works for me too.

[imath]

Thanks a lot for your test & feedback, I’ll commit it asap.

[imath]

In 13457:

BP Nouveau's message UI: make sure the reply action gets needed data

Adding a reply can be done by opening the thread view from the message UI or by directly accessing to this view from its URL.
In both cases, we need to make sure to get the current Thread ID in order to attach the reply to it.
As the Backbone Model or the fallback object are both including an id property, using it is a better choice than trying to access the Backbone Model's id attribute.

Props dave.pullig

Closes ​https://github.com/buddypress/buddypress/pull/89
See #8870 (trunk)

[imath]

In 13458:

BP Nouveau's message UI: make sure the reply action gets needed data

Adding a reply can be done by opening the thread view from the message UI or by directly accessing to this view from its URL.
In both cases, we need to make sure to get the current Thread ID in order to attach the reply to it.
As the Backbone Model or the fallback object are both including an id property, using it is a better choice than trying to access the Backbone Model's id attribute.

Props dave.pullig

Fixes #8870 (branch 11.0)