Skip to:
Content

BuddyPress.org

#8870 closed defect (bug) (fixed)

Unable to reply to messages via links in email notifications

Reported by: davepullig's profile dave.pullig Owned by: imath's profile imath
Milestone: 11.2.0 Priority: normal
Severity: normal Version: 11.1.0
Component: Messages Keywords: has-patch commit
Cc:

Description

This is a follow-up to #8825.

When replying to a message thread when you have followed a link from an email notification, it's not possible to send the reply - the following is logged in the the browser's console when the "Send reply" button is clicked:

Uncaught TypeError: e.has is not a function
buddypress-messages.min.js?ver=11.1.0:1 
 
    at n.sendReply (buddypress-messages.min.js?ver=11.1.0:1:22353)
    at HTMLDivElement.dispatch (jquery.min.js?ver=3.6.3:2:43184)
    at y.handle (jquery.min.js?ver=3.6.3:2:41168)

It's also possible to replicate this by refreshing the page having opened it from the inbox view, or by pasting the URL into the browser.

I've replicated this on a clean site with just BuddyPress & Twenty TwentyThree.

Change History (8)

#1 @imath
13 months ago

  • Milestone changed from Awaiting Review to 11.2.0

Hi @davepullig

Thanks for your report, I’ll look at it asap.

#2 @dave.pullig
13 months ago

Thanks @imath, happy to help test any patches.

This ticket was mentioned in PR #89 on buddypress/buddypress by @imath.


13 months ago
#3

  • Keywords has-patch added
  • Make sure the send action can get the Thread ID if the thread view was generated by opening the inbox view or thanks to the BackBone Router (direct URL access).
  • Make sure the Thread data used by the Thread's header is initialized as a BackBone Model.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/8870

#4 @imath
13 months ago

Awesome, I believe the above PR is fixing this issue.

#5 @dave.pullig
13 months ago

Yes, that works for me too.

#6 @imath
13 months ago

  • Keywords commit added

Thanks a lot for your test & feedback, I’ll commit it asap.

#7 @imath
13 months ago

In 13457:

BP Nouveau's message UI: make sure the reply action gets needed data

Adding a reply can be done by opening the thread view from the message UI or by directly accessing to this view from its URL.
In both cases, we need to make sure to get the current Thread ID in order to attach the reply to it.
As the Backbone Model or the fallback object are both including an id property, using it is a better choice than trying to access the Backbone Model's id attribute.

Props dave.pullig

Closes https://github.com/buddypress/buddypress/pull/89
See #8870 (trunk)

#8 @imath
13 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13458:

BP Nouveau's message UI: make sure the reply action gets needed data

Adding a reply can be done by opening the thread view from the message UI or by directly accessing to this view from its URL.
In both cases, we need to make sure to get the current Thread ID in order to attach the reply to it.
As the Backbone Model or the fallback object are both including an id property, using it is a better choice than trying to access the Backbone Model's id attribute.

Props dave.pullig

Fixes #8870 (branch 11.0)

Note: See TracTickets for help on using tickets.