Deleted field data are not removed from bp_xprofile_data

[mike80222]

When an xprofile field is deleted, the field is removed from bp_xprofile_fields, but the corresponding data is not removed from bp_xprofile_data. The upshot is that members_search finds both the old and the new data, resulting in incorrect search results.

Add a checkbox to let the admin also remove the deleted field data.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8864

[imath]

Hi @mike80222

Thanks a lot for your report. I confirm the issue. In the above PR, I'm adding a checkbox to the Delete field confirmation screen to opt-out field data removal. By default, deleted field data should be deleted I agree.

[imath]

In 13498:

xProfile: let the admin also remove data when deleting a field

Add a checkbox, active by default, informing deleting a field from the xProfile field Administration screen will also remove corresponding data. Opting out of this checkbox will let data in place.

Removing a deleted field corresponding data is improving Members search results consistency.

Props mike80222

Fixes #8864
Closes ​https://github.com/buddypress/buddypress/pull/114