Skip to:
Content

BuddyPress.org

Opened 21 months ago

Closed 19 months ago

#8858 closed defect (bug) (fixed)

Settings: Export Data page shows wrong information on successful export

Reported by: r-a-y's profile r-a-y Owned by: imath's profile imath
Milestone: 11.2.0 Priority: normal
Severity: normal Version: 6.4.0
Component: Settings Keywords: has-patch commit
Cc:

Description

Long time no see!

Was testing the Export Data page just now and found that our Export Data functions return wrong information since WordPress 5.5.

If you go to your profile's "Settings > Export Data" page and request a data export. After a site admin approves your request, navigate back to your "Settings > Export Data" page and you will see a "Your previous request for an export of personal data has expired" message. This message is wrong.

The problem is with our bp_settings_get_personal_data_export_url() and bp_settings_personal_data_export_exists() functions. These functions are using the '_export_file_path' post meta. This post meta was deprecated back in WordPress 5.5 in favor for the new '_export_file_name' meta entry: ​https://github.com/WordPress/WordPress/blob/1764cee3d1a7772992d04222dfcbd18084754eb6/wp-admin/includes/privacy-tools.php#L506-L510

I've updated our functions to use the newer meta entry.

Attachments (1)

8858.01.patch​ (1.4 KB) - added by r-a-y 21 months ago.

Download all attachments as: .zip

Change History (6)

@r-a-y
21 months ago

#1 @imath
21 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 12.0.0

Hi @r-a-y !

Great to see you. Thanks a lot for your catch & patch, it’s looking great. Feel free to commit it.

#2 @imath
20 months ago

  • Milestone changed from 12.0.0 to 11.2.0

As we're taking more time for 12.0, let's have this fixed earlier.

This ticket was mentioned in ​PR #97 on ​buddypress/buddypress by ​@imath.
19 months ago #3

Make sure a link to download personal data is available into front end Members Single Item data screen.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8858

#4 @imath
19 months ago

In 13473:

Make sure Export Data page shows right info on successful export

Once a user data file has been generated by the admin in reply to an export request, the corresponding front-end user's Settings Export Data page needs to show the link to download the generated file.

Props r-a-y

Closes ​https://github.com/buddypress/buddypress/pull/97
See #8858 (trunk)

#5 @imath
19 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13474:

Make sure Export Data page shows right info on successful export

Once a user data file has been generated by the admin in reply to an export request, the corresponding front-end user's Settings Export Data page needs to show the link to download the generated file.

Props r-a-y

Fixes #8858 (branch 11.0)

Note: See TracTickets for help on using tickets.