Message reply bug in v11.0.0

[casper99]

WordPress 6.1.1
Buddypress Version 11.0.0
Theme: bp-nouveau
Tested on PHP 7.4 and PHP 8.2

Hi, since last update, replying on messages is not possible any more.
New messages work.

Only the message “Your reply was not sent. Please enter some content.” appears.

Investigating the problem leads me to
bp-templates/bp-nouveau/includes/messages/ajax.php

The problem is, that $_POST[‘thread_id’] is empty.

$_POST
(
[nonce] => fc63ecc237
[action] => messages_send_reply
[content] => <p>test</p>
)

Any ideas?

[casper99]

Further invesigation.
The problem only occurs, if you use the site-menue to open the conversation.
You are being redirected to the message-thread by URL (german):
​https://example.com/mitglieder/testuser/view/420/

If i manually put the following URL (incl. "messages) into the browser, everything works.
​https://example.com/mitglieder/testuser/messages/view/420/

Maybe only an internal linking problem?

[imath]

Hi @casper99

Thanks for your report, could you add a screenshot so that I can see what you call « site-menue »? I’m not sure to understand what it is. Thanks in advance.

[casper99]

Hi @imath,

you can see in how i am using the usual way to open the message and send a reply. The link-destination is also shown.

Here, the error-message is shown

But if i manually type in the URL with "/messages/" (​https://example.com/mitglieder/testuser/messages/view/427/) in the browser, the reply is being sent.

But this is more a workaround than a solution. Sometimes the error still occurs. The main problem seems to be the missing "thread_id" in $_POST, as expected in bp-templates/bp-nouveau/includes/messages/ajax.php on line 181

[imath]

Hi @casper99

Thanks for your feedback 👍. I was able to reproduce the issue. This only happens when you open the messages view for the first time. As soon as you click on one of the link of the Massages toolbar (eg: Sent Messages), the link is well built.

Looking at it to find a fix.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8825

[imath]

In 13415:

BP Nouveau: Make sure the thread ID is transported into thread view

The Backbone based Messages UI of the Nouveau template pack is now looking for the displayed thread ID inside the messages collection if the current thread object hasn't been returned by the Ajax request. This prevent an error that was happening when trying to reply to a thread message after the thread has been displayed without re-requesting the server.

Props casper99

Closes ​https://github.com/buddypress/buddypress/pull/63
See #8825

[imath]

In 13416:

BP Nouveau: Make sure the thread ID is transported into thread view

The Backbone based Messages UI of the Nouveau template pack is now looking for the displayed thread ID inside the messages collection if the current thread object hasn't been returned by the Ajax request. This prevent an error that was happening when trying to reply to a thread message after the thread has been displayed without re-requesting the server.

Props casper99

Fixes #8825 (branch 11.0)