#8800 closed defect (bug) (fixed)
Avoid potential PHP errors when using BuddyPress buttons on front end
Reported by: | imath | Owned by: | imath |
---|---|---|---|
Milestone: | 11.1.0 | Priority: | high |
Severity: | major | Version: | 11.0.0 |
Component: | Templates | Keywords: | has-patch |
Cc: |
Description
[13299], [13300], [13301], [13302] & [13303] introduced a potential regression if the corresponding button arguments filter is used by some custom code like:
add_filter( 'bp_get_send_public_message_button', '__return_false' );
This was reported @fantamily by here: https://buddypress.org/support/topic/say-hi-to-buddypress-11-0-0-la-scala/#post-328004
Returning false to one the button arguments filter has two different effects depending on the active template pack:
- Legacy -> fatal error (Uncaught TypeError)
- Nouveau -> Warning (Trying to access array offset on value of type bool)
Change History (5)
This ticket was mentioned in PR #59 on buddypress/buddypress by @imath.
20 months ago
#1
- Keywords has-patch added; needs-patch removed
Trac ticket: https://buddypress.trac.wordpress.org/ticket/8800