PHP 8.1 fatal / PHP <8 notice+warning: Trying to get property 'ancestors' of non-object

[dd32]

The current PHP Notice is being triggered on BuddyPress.org, and is a Fatal error in PHP 8.1:

E_NOTICE: Trying to get property 'ancestors' of non-object in {file}
E_WARNING: in_array() expects parameter 2 to be array, null given in {file}

PHP 8.1 Fatal error: Uncaught Error: in_array(): Argument #2 ($haystack) must be of type array, null given
in {file}

Source: GET https://buddypress.org/users/dd32/

File: wp-content/plugins/buddypress/bp-core/bp-core-filters.php
Line: 202

See PR.

This merges in ​https://core.trac.wordpress.org/changeset/30157

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8760

[dd32]

Just noting that this is a E_WARNING in PHP <8 too, I just missed the fact that it's changed from E_NOTICE+E_WARNING to E_NOTICE+E_ERROR in the sea of notices I was looking at :)

[imath]

Hi @dd32

Thanks a lot for your report & patch 🤝. I'll commit it asap.

[imath]

In 13361:

Check a BuddyPress page exists before trying to access its properties

In bp_core_menu_highlight_parent_page() when trying to determine if the displayed page has a BuddyPress page ancestor, we need to make sure the potential BuddyPress page still exists to avoid a PHP notice/error.

Props dd32

Closes ​https://github.com/buddypress/buddypress/pull/35
See #8760 (trunk)

[imath]

In 13362:

Check a BuddyPress page exists before trying to access its properties

In bp_core_menu_highlight_parent_page() when trying to determine if the displayed page has a BuddyPress page ancestor, we need to make sure the potential BuddyPress page still exists to avoid a PHP notice/error.

Props dd32

Fixes #8760 (branch 10.0)