Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

#8689 closed defect (bug) (fixed)

Private Message send button can be clicked multiple times resulting in multiple messages and emails

Reported by: comminski's profile comminski Owned by: imath's profile imath
Milestone: 10.3.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: needs-patch
Cc:

Description

When you compose a new message, it's possible to click the 'Send' button multiple times, which results in the message being sent multiple times. This also results in the system sending out multiple emails to the message participants.

Steps to reproduce:

  1. Compose a new private message (members/me/messages/compose/)
  2. Click the Send button multiple times

Normally, once the ajax call completes, the page redirects to the 'sendbox' page, but if there is a slow internet connection, the user might be inclined to click the button many times, as there is also no indication here that the message is in the process of being sent.

Ideally, the button should be disabled while the network request is happening.

Change History (6)

#1 @imath
2 years ago

  • Keywords reporter-feedback added

Hi, thanks for your report.

I agree it's annoying, could you tell me what's the template pack you are using: BP Nouveau or BP Legacy?

If you don't know what's a template pack, simply check the Active template pack value in the BuddyPress panel of your-site.url/wp-admin/site-health.php?tab=debug

Thanks in advance for your help.

#2 @comminski
2 years ago

Hi @imath, thanks a lot for responding. I am using the Nouveau template pack and the Twenty Twenty One theme.

#3 @imath
2 years ago

  • Component changed from Messages to Templates
  • Keywords needs-patch added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 10.3.0
  • Owner set to imath
  • Status changed from new to assigned
  • Version changed from 10.2.0 to 3.0.0

Thanks a lot for your reply 👍. I’m currently working in this area on another ticket. I’ll include a fix to prevent this from happening.

#4 @comminski
2 years ago

Thats awesome, thanks @imath

#5 @imath
2 years ago

In 13278:

BP Nouveau: prevent anxious users to send a message more than once

In case the Ajax response takes a little more time to happen, frenetic clicks on the Messages UI "send" button are now neutralized.

Props comminski

See #8689 (trunk)

#6 @imath
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13279:

BP Nouveau: prevent anxious users to send a message more than once

In case the Ajax response takes a little more time to happen, frenetic clicks on the Messages UI "send" button are now neutralized.

Props comminski

Fixes #8689 (branch 10.0)

Note: See TracTickets for help on using tickets.